At a glance , looks great to me. Thanks so much for taking the time to do this right<br><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 19, 2016, 6:30 PM Tim Shen via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">timshen updated this revision to Diff 68756.<br>
timshen marked an inline comment as done.<br>
timshen added a comment.<br>
<br>
Added a testcase.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D23649" rel="noreferrer" target="_blank">https://reviews.llvm.org/D23649</a><br>
<br>
Files:<br>
include/llvm/ADT/DepthFirstIterator.h<br>
unittests/ADT/CMakeLists.txt<br>
unittests/ADT/DepthFirstIteratorTest.cpp<br>
unittests/ADT/SCCIteratorTest.cpp<br>
unittests/ADT/TestGraph.h<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>