<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 05/17/2016 11:40 AM, George Burgess
IV wrote:<br>
</div>
<blockquote
cite="mid:CAKh6zBF+P4OCW1U2ehn_ntr_Ci+E5EPK9Wt998ics1Eiwi9HjA@mail.gmail.com"
type="cite">
<div dir="ltr">> There are a couple of FIXME comments in this
change that identify cases where MemorySSA is maybe being too
conservative (e.g. when dealing with fence release instructions
and load atomic instructions).
<div><br>
</div>
<div>Yup! D16875 that should make MemSSA more willing to handle
atomics/volatile ops. Philip gave it a verbal LGTM*, but IIRC
he thought it may be better to wait until we get MSSA
integrated into a few passes (to get any big bugs worked out)
before we start making it super aggressive with memory
ordering. I have no opinion on when it should land; if we want
it in now, I'm happy to commit it today.</div>
<div><br>
</div>
<div>> <span style="font-size:12.8px">Similarly, what do you
think of Phillip's suggestion to look at using ValueHandles
in MemorySSA to make removal invalidating more automated?</span></div>
<br style="font-size:12.8px">
<div>I was planning for that to come with the overhauled cache
(most recent attempt is abandoned at D19503). I should have
more time to take another stab at it this weekend. If not,
I'll at least end up tweaking the current implementation to
use VHes.</div>
<div><br>
</div>
<div class="gmail_extra"><br>
</div>
<div class="gmail_extra">* - (To be as clear as I can be, it was
an LGTM with comments. Addressing the comments required
refactoring the code a bit. I'm assuming the refactoring
doesn't matter, and the LGTM still applies.)</div>
</div>
</blockquote>
It does.<br>
</body>
</html>