<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Aug 20, 2016 at 9:27 AM, Sebastian Pop via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">There were several fixes that went in last week.<br>
Have you tried with a recent top of tree compiler?<br>
<br>
If that still fails, I would need a reduced testcase or a diff of the<br>
IR that shows the wrong codegen.<br>
I can provide you instructions on how to get the diff once you confirm<br>
that ToT as of today is still broken.<br></blockquote><div><br></div><div>FWIW, there are a few open GVN-hoist bugs:</div><div><a href="https://llvm.org/bugs/show_bug.cgi?id=29023">https://llvm.org/bugs/show_bug.cgi?id=29023</a><br></div><div><a href="https://llvm.org/bugs/show_bug.cgi?id=29034">https://llvm.org/bugs/show_bug.cgi?id=29034</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Thanks,<br>
Sebastian<br>
<div class=""><div class="h5"><br>
On Sat, Aug 20, 2016 at 6:27 AM, Vasileios Kalintiris<br>
<<a href="mailto:Vasileios.Kalintiris@imgtec.com">Vasileios.Kalintiris@imgtec.<wbr>com</a>> wrote:<br>
> Hi Sebastian,<br>
><br>
> This broke the MIPS buildbots that do recursive builds. Could you revert the commit until we figure out what is causing the problem?<br>
><br>
> The problem is that 2 instructions from a single object file appear in the opposite order between Phase2 and Phase3.<br>
><br>
> Thanks,<br>
> Vasileios<br>
><br>
> ______________________________<wbr>__________<br>
> From: llvm-commits [<a href="mailto:llvm-commits-bounces@lists.llvm.org">llvm-commits-bounces@lists.<wbr>llvm.org</a>] on behalf of Sebastian Pop via llvm-commits [<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>]<br>
> Sent: 08 August 2016 15:46<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> Subject: [llvm] r278010 - GVN-hoist: enable by default<br>
><br>
> Author: spop<br>
> Date: Mon Aug 8 09:46:15 2016<br>
> New Revision: 278010<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=278010&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=278010&view=rev</a><br>
> Log:<br>
> GVN-hoist: enable by default<br>
><br>
> Modified:<br>
> llvm/trunk/lib/Transforms/IPO/<wbr>PassManagerBuilder.cpp<br>
> llvm/trunk/test/Feature/<wbr>optnone-opt.ll<br>
><br>
> Modified: llvm/trunk/lib/Transforms/IPO/<wbr>PassManagerBuilder.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=278010&r1=278009&r2=278010&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/IPO/<wbr>PassManagerBuilder.cpp?rev=<wbr>278010&r1=278009&r2=278010&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/Transforms/IPO/<wbr>PassManagerBuilder.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/IPO/<wbr>PassManagerBuilder.cpp Mon Aug 8 09:46:15 2016<br>
> @@ -138,8 +138,8 @@ static cl::opt<int> PreInlineThreshold(<br>
> "(default = 75)"));<br>
><br>
> static cl::opt<bool> EnableGVNHoist(<br>
> - "enable-gvn-hoist", cl::init(false), cl::Hidden,<br>
> - cl::desc("Enable the experimental GVN Hoisting pass"));<br>
> + "enable-gvn-hoist", cl::init(true), cl::Hidden,<br>
> + cl::desc("Enable the GVN hoisting pass (default = on)"));<br>
><br>
> PassManagerBuilder::<wbr>PassManagerBuilder() {<br>
> OptLevel = 2;<br>
><br>
> Modified: llvm/trunk/test/Feature/<wbr>optnone-opt.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/optnone-opt.ll?rev=278010&r1=278009&r2=278010&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>Feature/optnone-opt.ll?rev=<wbr>278010&r1=278009&r2=278010&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/Feature/<wbr>optnone-opt.ll (original)<br>
> +++ llvm/trunk/test/Feature/<wbr>optnone-opt.ll Mon Aug 8 09:46:15 2016<br>
> @@ -41,6 +41,7 @@ attributes #0 = { optnone noinline }<br>
> ; OPT-O1-DAG: Skipping pass 'Combine redundant instructions'<br>
> ; OPT-O1-DAG: Skipping pass 'Dead Store Elimination'<br>
> ; OPT-O1-DAG: Skipping pass 'Early CSE'<br>
> +; OPT-O1-DAG: Skipping pass 'Early GVN Hoisting of Expressions'<br>
> ; OPT-O1-DAG: Skipping pass 'Jump Threading'<br>
> ; OPT-O1-DAG: Skipping pass 'MemCpy Optimization'<br>
> ; OPT-O1-DAG: Skipping pass 'Reassociate expressions'<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>