<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Lang,<div class=""><br class=""></div><div class="">That's great, thank you so much. I'm glad you took a look because most of what you just said went over my head. :)</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">- Will</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 18, 2016, at 6:25 PM, Lang Hames <<a href="mailto:lhames@gmail.com" class="">lhames@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi William,<div class=""><br class=""></div><div class="">Daniel told me you were still hoping to land this, so I took a stab at writing a test for it and discovered that, unfortunately, RuntimeDyldELF's GOT building mechanism (which uses a separate section for GOT entries) isn't compatible with RuntimeDyldChecker.</div><div class=""><br class=""></div><div class="">The proper solution to that is to fix RuntimeDyldELF's GOT handling (it's not safe to use a separate section in general, as it may be allocated out of range of a PC-rel GOT entry load), but that's non-trivial.</div><div class=""><br class=""></div><div class="">In the mean time, since this patch doesn't change any existing behavior I've committed in r279182.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Lang.</div><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Mar 22, 2016 at 1:05 PM, Lang Hames via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">Hi Michael, William,<div class=""><br class=""></div><div class="">William - thank you very much for this!</div><div class=""><br class=""></div><div class="">If possible, could you please add an ELF test case to llvm/test/ExecutionEngine/<wbr class="">RuntimeDyld/ARM? There is an existing MachO test case there that may be of some help, though it does not contain any GOT relocation tests. From the x86-64 GOT test:</div><div class=""><br class=""></div><div class=""><font face="Courier New" class=""># Test PC-rel GOT relocation.<br class=""># Verify both the contents of the GOT entry for y, and that the movq instruction<br class=""># references the correct GOT entry address:<br class=""># rtdyld-check: *{8}(stub_addr(test_x86-64.o, __text, y)) = y<br class=""># rtdyld-check: decode_operand(insn3, 4) = stub_addr(test_x86-64.o, __text, y) - next_pc(insn3)<br class="">insn3:<br class=""> movq y@GOTPCREL(%rip), %rax<br class=""></font><br class=""></div><div class="">The first test is reading the value of the stub (in this case GOT entry) for y and verifying that it contains the address of y.</div><div class="">The second test is verifying that the PC-relative offset for the instruction is equal to the difference between the stub address and the next instruction.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Lang.</div><span class=""><div class=""><br class=""></div><div class=""><div class=""><blockquote type="cite" class=""><div class="">On Mar 22, 2016, at 12:58 PM, Michael Gottesman <<a href="mailto:mgottesman@apple.com" target="_blank" class="">mgottesman@apple.com</a>> wrote:</div><br class=""><div class=""><div class="">I am not actually reviewing this, but just as a drive by: This is definitely going to need tests.<br class=""><br class=""><blockquote type="cite" class="">On Mar 22, 2016, at 12:56 PM, Michael Gottesman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""><br class="">Lang, can you take a look at this one?<br class=""><br class=""><blockquote type="cite" class="">On Mar 22, 2016, at 10:59 AM, William Dillon via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""><br class=""><llvm.patch>This change supports the swift interpreter on armv7-based linux machines. This is required for a number of tests and the package manager.<br class=""><br class="">- Will__________________________<wbr class="">_____________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class=""></blockquote><br class="">______________________________<wbr class="">_________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class=""></blockquote><br class=""></div></div></blockquote></div><br class=""></div></span></div><br class="">______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
<br class=""></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>