<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 17, 2016 at 2:56 PM, Justin Bogner <span dir="ltr"><<a href="mailto:mail@justinbogner.com" target="_blank">mail@justinbogner.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span class="gmail-">Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> writes:<br>
> FYI: this broke libFuzzer.<br>
> libFuzzer does not (and should not) include any of the LLVM headers,<br>
> and so LLVM_FALLTHROUGH is not defined.<br>
> fixed in 278982<br>
<br>
</span>Oops, sorry about that. I still don't really understand why libfuzzer<br>
doesn't refer to any LLVM headers (especially Compiler.h, which is<br>
purely cross compiler compatibility), but so be it.<br></blockquote><div><br></div><div><a href="http://llvm.org/docs/LibFuzzer.html#q-why-doesn-t-libfuzzer-use-any-of-the-llvm-support">http://llvm.org/docs/LibFuzzer.html#q-why-doesn-t-libfuzzer-use-any-of-the-llvm-support</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
It's curious that this didn't fail locally though - does libfuzzer not<br>
build by default?<br></blockquote><div><br></div><div>It does not. Currently it requires a separate build (covered by a bot): </div><div><a href="http://llvm.org/docs/LibFuzzer.html#developing-libfuzzer">http://llvm.org/docs/LibFuzzer.html#developing-libfuzzer</a><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
> --kcc<br>
><br>
> On Wed, Aug 17, 2016 at 1:30 PM, Justin Bogner via llvm-commits <<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
>> Author: bogner<br>
>> Date: Wed Aug 17 15:30:52 2016<br>
>> New Revision: 278970<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=278970&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=278970&view=rev</a><br>
>> Log:<br>
>> Replace a few more "fall through" comments with LLVM_FALLTHROUGH<br>
>><br>
>> Follow up to r278902. I had missed "fall through", with a space.<br>
>><br>
>><br>
>> Modified: llvm/trunk/lib/Fuzzer/<wbr>FuzzerMutate.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Fuzzer/</a><br>
>> FuzzerMutate.cpp?rev=278970&<wbr>r1=278969&r2=278970&view=diff<br>
>> ==============================<wbr>==============================<br>
>> ==================<br>
>> --- llvm/trunk/lib/Fuzzer/<wbr>FuzzerMutate.cpp (original)<br>
>> +++ llvm/trunk/lib/Fuzzer/<wbr>FuzzerMutate.cpp Wed Aug 17 15:30:52 2016<br>
>> @@ -286,7 +286,7 @@ size_t MutationDispatcher::Mutate_<wbr>CrossO<br>
>>        NewSize = InsertPartOf(O.data(), O.size(), U.data(), U.size(),<br>
>> MaxSize);<br>
>>        if (NewSize)<br>
>>          break;<br>
>> -      // Fallthrough<br>
>> +      LLVM_FALLTHROUGH;<br>
>>      case 2:<br>
>>        NewSize = CopyPartOf(O.data(), O.size(), U.data(), U.size());<br>
>>        break;<br>
>><br>
>><br>
</div></div></blockquote></div><br></div></div>