<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Actually no, I see no real benefits from it.<br>
</p>
<p>But noticable positive moment is that <span style="color: rgb(33, 33, 33); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; background-color: rgb(255, 255, 255);">--no-gnu-unique</span> option <span style="font-size: 12pt;">do what described
for -r.</span></p>
<p><span style="font-size: 12pt;">It might be confusing that with and without -r it works differently, there is no</span></p>
<p><span style="font-size: 12pt;">warning about and we probably do not want to document that difference,</span></p>
<p><span style="font-size: 12pt;">so I have little prefference to go with my version here, though your one has</span></p>
<p><span style="font-size: 12pt;">simpler logic and also should work for users as scenario to use -r and <span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; color: rgb(33, 33, 33); background-color: rgb(255, 255, 255);">--no-gnu-unique</span><span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; background-color: rgb(255, 255, 255);"></span>
together</span></p>
<p><span style="font-size: 12pt;">does not look as high user path for me.</span></p>
<p><br>
</p>
<div id="Signature">
<div class="BodyFragment"><font size="2">
<div class="PlainText">Best regards,<br>
George.<br>
</div>
</font></div>
</div>
<div style="color: rgb(33, 33, 33);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>От:</b> Rui Ueyama <ruiu@google.com><br>
<b>Отправлено:</b> 16 августа 2016 г. 23:36<br>
<b>Кому:</b> reviews+D23514+public+a2377f544def6982@reviews.llvm.org<br>
<b>Копия:</b> George Rimar; Rafael Ávila de Espíndola; evgeny777; llvm-commits<br>
<b>Тема:</b> Re: [PATCH] D23514: [ELF] - Do not change binding for hidden symbols when creating relocatable output.</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Mon, Aug 15, 2016 at 11:02 PM, George Rimar <span dir="ltr">
<<a href="mailto:grimar@accesssoftek.com" target="_blank">grimar@accesssoftek.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
grimar added inline comments.<br>
<span class=""><br>
================<br>
Comment at: ELF/OutputSections.cpp:1319<br>
@@ -1318,2 +1318,3 @@<br>
</span><span class=""> Symbol *S = Body->symbol();<br>
uint8_t Visibility = S->Visibility;<br>
</span><span class="">+ if (!Config->Relocatable)<br>
----------------<br>
</span><span class="">ruiu wrote:<br>
> I'm not sure if this would fix the problem entirely. My gut is that we want to keep the original symbol type if -r is specified. If that's the case, we want to add<br>
><br>
> if (Config->Relocatable)<br>
> return S->Binding;<br>
><br>
> here. But I don't know if that's correct.<br>
</span>gold allows GNU_UNIQUE->STB_GLOBAL transformation for relocatable output,<br>
so I tried to be consistent with it here.<br>
That is the only difference with your suggestion I think. And looks gnu ld does not support<br>
--no-gnu-unique at all, so probably we can go with any solution here.<br>
</blockquote>
<div><br>
</div>
<div>Do you think what GNU gold does makes sense? </div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>