<div dir="ltr">Sorry about that, should be fixed in <a href="https://reviews.llvm.org/D23635">https://reviews.llvm.org/D23635</a> .</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 17, 2016 at 1:59 PM, Justin Bogner <span dir="ltr"><<a href="mailto:mail@justinbogner.com" target="_blank">mail@justinbogner.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">"Duncan P. N. Exon Smith via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>><br>
writes:<br>
<span class="">> Reverted in r278973. I think you need some lit logic so that this<br>
> only builds when the WebAssembly target is enabled (the bots weren't<br>
> very happy).<br>
<br>
</span>Specifically, what's needed here is a lit.local.cfg much like the ones<br>
in the other targets' DebugInfo/${target}/ directories.<br>
<div class="HOEnZb"><div class="h5"><br>
>> On 2016-Aug-17, at 13:11, Dominic Chen via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: ddcc<br>
>> Date: Wed Aug 17 15:11:03 2016<br>
>> New Revision: 278967<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=278967&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=278967&view=rev</a><br>
>> Log:<br>
>> [WebAssembly] Handle debug information and virtual registers without crashing<br>
>><br>
>> Summary: Currently, enabling debug information when compiling for WebAssembly crashes the backend. This commit fixes these by skipping debug values in backend passes.<br>
>><br>
>> Reviewers: jfb, aprantl, dschuff, echristo<br>
>><br>
>> Subscribers: mehdi_amini, yurydelendik, dexonsmith, MatzeB, jfb, dschuff, llvm-commits<br>
>><br>
>> Differential Revision: <a href="https://reviews.llvm.org/D21808" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D21808</a><br>
>><br>
>> Added:<br>
>> llvm/trunk/test/DebugInfo/<wbr>WebAssembly/<br>
>> llvm/trunk/test/DebugInfo/<wbr>WebAssembly/dbg-declare.ll<br>
>> Modified:<br>
>> llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyRegStackify.cpp<br>
>> llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyReplacePhysRegs.cpp<br>
>> llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyStoreResults.cpp<br>
>><br>
>> Modified: llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyRegStackify.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp?rev=278967&r1=278966&r2=278967&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyRegStackify.cpp?<wbr>rev=278967&r1=278966&r2=<wbr>278967&view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyRegStackify.cpp (original)<br>
>> +++ llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyRegStackify.cpp Wed Aug 17 15:11:03 2016<br>
>> @@ -255,7 +255,7 @@ static bool HasOneUse(unsigned Reg, Mach<br>
>> const VNInfo *DefVNI = LI.getVNInfoAt(<br>
>> LIS.getInstructionIndex(*Def).<wbr>getRegSlot());<br>
>> assert(DefVNI);<br>
>> - for (auto I : MRI.use_nodbg_operands(Reg)) {<br>
>> + for (auto &I : MRI.use_nodbg_operands(Reg)) {<br>
>> const auto &Result = LI.Query(LIS.<wbr>getInstructionIndex(*I.<wbr>getParent()));<br>
>> if (Result.valueIn() == DefVNI) {<br>
>> if (!Result.isKill())<br>
>> @@ -360,7 +360,7 @@ static bool OneUseDominatesOtherUses(uns<br>
>> const MachineInstr *OneUseInst = OneUse.getParent();<br>
>> VNInfo *OneUseVNI = LI.getVNInfoBefore(LIS.<wbr>getInstructionIndex(*<wbr>OneUseInst));<br>
>><br>
>> - for (const MachineOperand &Use : MRI.use_operands(Reg)) {<br>
>> + for (const MachineOperand &Use : MRI.use_nodbg_operands(Reg)) {<br>
>> if (&Use == &OneUse)<br>
>> continue;<br>
>><br>
>><br>
>> Modified: llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyReplacePhysRegs.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyReplacePhysRegs.cpp?rev=278967&r1=278966&r2=278967&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyReplacePhysRegs.<wbr>cpp?rev=278967&r1=278966&r2=<wbr>278967&view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyReplacePhysRegs.cpp (original)<br>
>> +++ llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyReplacePhysRegs.cpp Wed Aug 17 15:11:03 2016<br>
>> @@ -88,6 +88,8 @@ bool WebAssemblyReplacePhysRegs::<wbr>runOnMa<br>
>> if (VReg == WebAssembly::NoRegister)<br>
>> VReg = MRI.createVirtualRegister(RC);<br>
>> MO.setReg(VReg);<br>
>> + if (MO.getParent()->isDebugValue(<wbr>))<br>
>> + MO.setIsDebug();<br>
>> Changed = true;<br>
>> }<br>
>> }<br>
>><br>
>> Modified: llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyStoreResults.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyStoreResults.cpp?rev=278967&r1=278966&r2=278967&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyStoreResults.cpp?<wbr>rev=278967&r1=278966&r2=<wbr>278967&view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyStoreResults.cpp (original)<br>
>> +++ llvm/trunk/lib/Target/<wbr>WebAssembly/<wbr>WebAssemblyStoreResults.cpp Wed Aug 17 15:11:03 2016<br>
>> @@ -90,7 +90,7 @@ static bool ReplaceDominatedUses(Machine<br>
>><br>
>> SmallVector<SlotIndex, 4> Indices;<br>
>><br>
>> - for (auto I = MRI.use_begin(FromReg), E = MRI.use_end(); I != E;) {<br>
>> + for (auto I = MRI.use_nodbg_begin(FromReg), E = MRI.use_nodbg_end(); I != E;) {<br>
>> MachineOperand &O = *I++;<br>
>> MachineInstr *Where = O.getParent();<br>
>><br>
>><br>
>> Added: llvm/trunk/test/DebugInfo/<wbr>WebAssembly/dbg-declare.ll<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/WebAssembly/dbg-declare.ll?rev=278967&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>DebugInfo/WebAssembly/dbg-<wbr>declare.ll?rev=278967&view=<wbr>auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- llvm/trunk/test/DebugInfo/<wbr>WebAssembly/dbg-declare.ll (added)<br>
>> +++ llvm/trunk/test/DebugInfo/<wbr>WebAssembly/dbg-declare.ll Wed Aug 17 15:11:03 2016<br>
>> @@ -0,0 +1,75 @@<br>
>> +; RUN: llc < %s -verify-machineinstrs -mtriple=wasm32-unknown-<wbr>unknown | FileCheck %s<br>
>> +; RUN: llc < %s -verify-machineinstrs -mtriple=wasm32-unknown-<wbr>unknown -fast-isel | FileCheck --check-prefix=CHECK-FAST %s<br>
>> +; CHECK: #DEBUG_VALUE: decode:i <- [%vreg<br>
>> +; CHECK: #DEBUG_VALUE: decode:v <- [%vreg<br>
>> +; CHECK: DW_TAG_variable<br>
>> +; CHECK-FAST: DW_TAG_variable<br>
>> +<br>
>> +; Test that llvm.dbg.declare() instrinsics do not crash the backend<br>
>> +<br>
>> +target datalayout = "e-m:e-p:32:32-i64:64-n32:64-<wbr>S128"<br>
>> +target triple = "wasm32-unknown-unknown"<br>
>> +<br>
>> +%0 = type opaque<br>
>> +<br>
>> +@key = external global [15 x i8], align 1<br>
>> +<br>
>> +; Function Attrs: nounwind<br>
>> +define internal zeroext i8 @0(i32, i8 zeroext) !dbg !14 !type !19 {<br>
>> + %3 = alloca i32, align 4<br>
>> + %4 = alloca i8, align 1<br>
>> + store i32 %0, i32* %3, align 4<br>
>> + call void @llvm.dbg.declare(metadata i32* %3, metadata !20, metadata !21), !dbg !22<br>
>> + store i8 %1, i8* %4, align 1<br>
>> + call void @llvm.dbg.declare(metadata i8* %4, metadata !23, metadata !21), !dbg !24<br>
>> + %5 = load i8, i8* %4, align 1, !dbg !25<br>
>> + %6 = zext i8 %5 to i32, !dbg !25<br>
>> + %7 = load i32, i32* %3, align 4, !dbg !26<br>
>> + %8 = urem i32 %7, 15, !dbg !27<br>
>> + %9 = getelementptr inbounds [15 x i8], [15 x i8]* @key, i32 0, i32 %8, !dbg !28<br>
>> + %10 = load i8, i8* %9, align 1, !dbg !28<br>
>> + %11 = zext i8 %10 to i32, !dbg !28<br>
>> + %12 = xor i32 %6, %11, !dbg !29<br>
>> + %13 = trunc i32 %12 to i8, !dbg !30<br>
>> + ret i8 %13, !dbg !31<br>
>> +}<br>
>> +<br>
>> +; Function Attrs: nounwind readnone<br>
>> +declare void @llvm.dbg.declare(metadata, metadata, metadata)<br>
>> +<br>
>> +!<a href="http://llvm.dbg.cu" rel="noreferrer" target="_blank">llvm.dbg.cu</a> = !{!0}<br>
>> +!llvm.module.flags = !{!11, !12}<br>
>> +!llvm.ident = !{!13}<br>
>> +<br>
>> +!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.9.0 (trunk 273884) (llvm/trunk 273897)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, globals: !3)<br>
>> +!1 = !DIFile(filename: "crash.c", directory: "wasm/tests")<br>
>> +!2 = !{}<br>
>> +!3 = !{!4}<br>
>> +!4 = distinct !DIGlobalVariable(name: "key", scope: !0, file: !1, line: 7, type: !5, isLocal: false, isDefinition: true, variable: [15 x i8]* @key)<br>
>> +!5 = !DICompositeType(tag: DW_TAG_array_type, baseType: !6, size: 120, align: 8, elements: !9)<br>
>> +!6 = !DIDerivedType(tag: DW_TAG_typedef, name: "uint8_t", file: !7, line: 185, baseType: !8)<br>
>> +!7 = !DIFile(filename: "wasm/emscripten/system/<wbr>include/libc/bits/alltypes.h", directory: "wasm/tests")<br>
>> +!8 = !DIBasicType(name: "unsigned char", size: 8, align: 8, encoding: DW_ATE_unsigned_char)<br>
>> +!9 = !{!10}<br>
>> +!10 = !DISubrange(count: 15)<br>
>> +!11 = !{i32 2, !"Dwarf Version", i32 4}<br>
>> +!12 = !{i32 2, !"Debug Info Version", i32 3}<br>
>> +!13 = !{!"clang version 3.9.0 (trunk 273884) (llvm/trunk 273897)"}<br>
>> +!14 = distinct !DISubprogram(name: "decode", scope: !1, file: !1, line: 11, type: !15, isLocal: false, isDefinition: true, scopeLine: 11, flags: DIFlagPrototyped, isOptimized: false, unit: !0, variables: !2)<br>
>> +!15 = !DISubroutineType(types: !16)<br>
>> +!16 = !{!6, !17, !6}<br>
>> +!17 = !DIDerivedType(tag: DW_TAG_typedef, name: "size_t", file: !7, line: 124, baseType: !18)<br>
>> +!18 = !DIBasicType(name: "long unsigned int", size: 32, align: 32, encoding: DW_ATE_unsigned)<br>
>> +!19 = !{i64 0, !"_ZTSFhmhE"}<br>
>> +!20 = !DILocalVariable(name: "i", arg: 1, scope: !14, file: !1, line: 11, type: !17)<br>
>> +!21 = !DIExpression()<br>
>> +!22 = !DILocation(line: 11, column: 23, scope: !14)<br>
>> +!23 = !DILocalVariable(name: "v", arg: 2, scope: !14, file: !1, line: 11, type: !6)<br>
>> +!24 = !DILocation(line: 11, column: 34, scope: !14)<br>
>> +!25 = !DILocation(line: 12, column: 11, scope: !14)<br>
>> +!26 = !DILocation(line: 12, column: 19, scope: !14)<br>
>> +!27 = !DILocation(line: 12, column: 21, scope: !14)<br>
>> +!28 = !DILocation(line: 12, column: 15, scope: !14)<br>
>> +!29 = !DILocation(line: 12, column: 13, scope: !14)<br>
>> +!30 = !DILocation(line: 12, column: 10, scope: !14)<br>
>> +!31 = !DILocation(line: 12, column: 3, scope: !14)<br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>