<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Aug 7, 2016 at 11:57 PM, Mehdi Amini <span dir="ltr"><<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On Aug 7, 2016, at 11:43 PM, Chandler Carruth via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_quote"><div dir="ltr">On Sun, Aug 7, 2016 at 10:46 PM Sean Silva via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: silvas<br>Date: Mon Aug  8 00:38:06 2016<br>New Revision: 277982<br><br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project?rev=277982&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/<wbr>llvm-project?rev=277982&view=<wbr>rev</a><br>Log:<br>[PM] More workaround for PR28400<br></blockquote><div><br></div><div>See my replies on the other threads.</div><div><br></div><div>This does not seem to be a reasonable thing to land without review, and if it is it really needs a better change description than this.</div></div></div></div></blockquote><div><br></div></span><div>FWIW I felt the same seeing this commits when it came through.</div><div><br></div><div>I assume it is done for good reasons, but the commit title isn’t clear by itself and the PR linked is quite broad.</div></div></div></blockquote><div><br></div><div>I've updated that PR to give a bit more explanation. Let me know if there's something else I should add there.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><div> There is not comment in the code to figure out either so one may only guess.</div><div>(especially since it mentions this being a “workaround”, I’d expect it to be clear in the code as a comment or something)</div></div></div></blockquote><div><br></div><div>Sorry about that, and thanks for the suggestion! I've added the comments in r277984.</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><div><br></div><div>— </div><span class=""><font color="#888888"><div>Mehdi</div></font></span><div><div class="h5"><div><br></div><div><br></div><div><br></div><blockquote type="cite"><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>Modified:<br>   <span> </span>llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>AlignmentFromAssumptions.cpp<br>   <span> </span>llvm/trunk/lib/Transforms/<wbr>Scalar/NaryReassociate.cpp<br>   <span> </span>llvm/trunk/lib/Transforms/<wbr>Utils/LoopSimplify.cpp<br><br>Modified: llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>AlignmentFromAssumptions.cpp<br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp?rev=277982&r1=277981&r2=277982&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/<wbr>llvm-project/llvm/trunk/lib/<wbr>Transforms/Scalar/<wbr>AlignmentFromAssumptions.cpp?<wbr>rev=277982&r1=277981&r2=<wbr>277982&view=diff</a><br>==============================<wbr>==============================<wbr>==================<br>--- llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>AlignmentFromAssumptions.cpp (original)<br>+++ llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>AlignmentFromAssumptions.cpp Mon Aug  8 00:38:06 2016<br>@@ -434,6 +434,7 @@ AlignmentFromAssumptionsPass::<wbr>run(Functi<br>   ScalarEvolution &SE = AM.getResult<<wbr>ScalarEvolutionAnalysis>(F);<br>   DominatorTree &DT = AM.getResult<<wbr>DominatorTreeAnalysis>(F);<br>   bool Changed = runImpl(F, AC, &SE, &DT);<br>+  AM.invalidate<<wbr>ScalarEvolutionAnalysis>(F);<br>   if (!Changed)<br>     return PreservedAnalyses::all();<br>   PreservedAnalyses PA;<br><br>Modified: llvm/trunk/lib/Transforms/<wbr>Scalar/NaryReassociate.cpp<br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp?rev=277982&r1=277981&r2=277982&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/<wbr>llvm-project/llvm/trunk/lib/<wbr>Transforms/Scalar/<wbr>NaryReassociate.cpp?rev=<wbr>277982&r1=277981&r2=277982&<wbr>view=diff</a><br>==============================<wbr>==============================<wbr>==================<br>--- llvm/trunk/lib/Transforms/<wbr>Scalar/NaryReassociate.cpp (original)<br>+++ llvm/trunk/lib/Transforms/<wbr>Scalar/NaryReassociate.cpp Mon Aug  8 00:38:06 2016<br>@@ -157,6 +157,7 @@ PreservedAnalyses NaryReassociatePass::r<br>   auto *TTI = &AM.getResult<<wbr>TargetIRAnalysis>(F);<br><br>   bool Changed = runImpl(F, AC, DT, SE, TLI, TTI);<br>+  AM.invalidate<<wbr>ScalarEvolutionAnalysis>(F);<br>   if (!Changed)<br>     return PreservedAnalyses::all();<br><br><br>Modified: llvm/trunk/lib/Transforms/<wbr>Utils/LoopSimplify.cpp<br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp?rev=277982&r1=277981&r2=277982&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/<wbr>llvm-project/llvm/trunk/lib/<wbr>Transforms/Utils/LoopSimplify.<wbr>cpp?rev=277982&r1=277981&r2=<wbr>277982&view=diff</a><br>==============================<wbr>==============================<wbr>==================<br>--- llvm/trunk/lib/Transforms/<wbr>Utils/LoopSimplify.cpp (original)<br>+++ llvm/trunk/lib/Transforms/<wbr>Utils/LoopSimplify.cpp Mon Aug  8 00:38:06 2016<br>@@ -869,6 +869,8 @@ PreservedAnalyses LoopSimplifyPass::run(<br>   for (LoopInfo::iterator I = LI->begin(), E = LI->end(); I != E; ++I)<br>     Changed |= simplifyLoop(*I, DT, LI, SE, AC, true /* PreserveLCSSA */);<br><br>+  AM.invalidate<<wbr>ScalarEvolutionAnalysis>(F);<br>+<br>   if (!Changed)<br>     return PreservedAnalyses::all();<br>   PreservedAnalyses PA;<br><br><br>______________________________<wbr>_________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br></blockquote></div></div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">______________________________<wbr>_________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">llvm-commits mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="mailto:llvm-commits@lists.llvm.org" style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">llvm-commits@lists.llvm.org</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" style="font-family:Helvetica;font-size:12px;font-style:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a></div></blockquote></div></div></div><br></div></blockquote></div><br></div></div>