<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Aug 7, 2016 at 11:43 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class=""><div dir="ltr">On Sun, Aug 7, 2016 at 10:46 PM Sean Silva via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: silvas<br>
Date: Mon Aug 8 00:38:06 2016<br>
New Revision: 277982<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277982&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=277982&view=rev</a><br>
Log:<br>
[PM] More workaround for PR28400<br></blockquote><div><br></div></span><div>See my replies on the other threads.</div><div><br></div><div>This does not seem to be a reasonable thing to land without review, and if it is it really needs a better change description than this.</div></div></div></blockquote><div><br></div><div><div style="font-size:12.8px">This is related to the thread "Should analyses be able to hold AssertingVH to IR? (related to PR28400)".</div><span class="im" style="font-size:12.8px"><div><br></div></span><div style="font-size:12.8px">I described this workaround in that thread and there didn't seem to be any objections to doing that for now.</div></div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">I agree that I should have provided a bit more context in the commit message. I committed this in close temporal locality with r277980 so I had it on the mind and didn't think twice. Sorry about that.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>AlignmentFromAssumptions.cpp<br>
llvm/trunk/lib/Transforms/<wbr>Scalar/NaryReassociate.cpp<br>
llvm/trunk/lib/Transforms/<wbr>Utils/LoopSimplify.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>AlignmentFromAssumptions.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp?rev=277982&r1=277981&r2=277982&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Scalar/<wbr>AlignmentFromAssumptions.cpp?<wbr>rev=277982&r1=277981&r2=<wbr>277982&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>AlignmentFromAssumptions.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/<wbr>Scalar/<wbr>AlignmentFromAssumptions.cpp Mon Aug 8 00:38:06 2016<br>
@@ -434,6 +434,7 @@ AlignmentFromAssumptionsPass::<wbr>run(Functi<br>
ScalarEvolution &SE = AM.getResult<<wbr>ScalarEvolutionAnalysis>(F);<br>
DominatorTree &DT = AM.getResult<<wbr>DominatorTreeAnalysis>(F);<br>
bool Changed = runImpl(F, AC, &SE, &DT);<br>
+ AM.invalidate<<wbr>ScalarEvolutionAnalysis>(F);<br>
if (!Changed)<br>
return PreservedAnalyses::all();<br>
PreservedAnalyses PA;<br>
<br>
Modified: llvm/trunk/lib/Transforms/<wbr>Scalar/NaryReassociate.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp?rev=277982&r1=277981&r2=277982&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Scalar/<wbr>NaryReassociate.cpp?rev=<wbr>277982&r1=277981&r2=277982&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Transforms/<wbr>Scalar/NaryReassociate.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/<wbr>Scalar/NaryReassociate.cpp Mon Aug 8 00:38:06 2016<br>
@@ -157,6 +157,7 @@ PreservedAnalyses NaryReassociatePass::r<br>
auto *TTI = &AM.getResult<<wbr>TargetIRAnalysis>(F);<br>
<br>
bool Changed = runImpl(F, AC, DT, SE, TLI, TTI);<br>
+ AM.invalidate<<wbr>ScalarEvolutionAnalysis>(F);<br>
if (!Changed)<br>
return PreservedAnalyses::all();<br>
<br>
<br>
Modified: llvm/trunk/lib/Transforms/<wbr>Utils/LoopSimplify.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp?rev=277982&r1=277981&r2=277982&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Utils/LoopSimplify.<wbr>cpp?rev=277982&r1=277981&r2=<wbr>277982&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Transforms/<wbr>Utils/LoopSimplify.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/<wbr>Utils/LoopSimplify.cpp Mon Aug 8 00:38:06 2016<br>
@@ -869,6 +869,8 @@ PreservedAnalyses LoopSimplifyPass::run(<br>
for (LoopInfo::iterator I = LI->begin(), E = LI->end(); I != E; ++I)<br>
Changed |= simplifyLoop(*I, DT, LI, SE, AC, true /* PreserveLCSSA */);<br>
<br>
+ AM.invalidate<<wbr>ScalarEvolutionAnalysis>(F);<br>
+<br>
if (!Changed)<br>
return PreservedAnalyses::all();<br>
PreservedAnalyses PA;<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div></div>
</blockquote></div><br></div></div>