<div dir="ltr">Thanks for reverting this (hopefully the heads-up in IRC saved you some time). Thankfully this is just an optimization so reverting this isn't a big deal.<div><br></div><div>For anybody that feels like chasing this down: I'm guessing this is due to MSVC getting confused about the SFINAE check in `class ResultHasInvalidateMethod` in llvm/include/llvm/IR/PassManagerInternal.h when there are two `run` methods, but that's just a guess.<div><br></div><div><div>-- Sean Silva</div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 8, 2016 at 7:51 AM, Nico Weber via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: nico<br>
Date: Mon Aug  8 09:51:53 2016<br>
New Revision: 278011<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=278011&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=278011&view=rev</a><br>
Log:<br>
Revert r2277979.<br>
<br>
For some reason, MSVC2013's cl.exe crashes with<br>
  fatal error C1001: An internal error has occurred in the compiler<br>
with this when compiling e.g. LoopDistribute.cpp.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/<wbr>Analysis/TargetLibraryInfo.h<br>
<br>
Modified: llvm/trunk/include/llvm/<wbr>Analysis/TargetLibraryInfo.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/TargetLibraryInfo.h?rev=278011&r1=278010&r2=278011&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/Analysis/<wbr>TargetLibraryInfo.h?rev=<wbr>278011&r1=278010&r2=278011&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/<wbr>Analysis/TargetLibraryInfo.h (original)<br>
+++ llvm/trunk/include/llvm/<wbr>Analysis/TargetLibraryInfo.h Mon Aug  8 09:51:53 2016<br>
@@ -273,7 +273,6 @@ public:<br>
   /// If we try to invalidate this info, just return false. It cannot become<br>
   /// invalid even if the module changes.<br>
   bool invalidate(Module &, const PreservedAnalyses &) { return false; }<br>
-  bool invalidate(Function &, const PreservedAnalyses &) { return false; }<br>
 };<br>
<br>
 /// Analysis pass providing the \c TargetLibraryInfo.<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>