<div dir="ltr">ACK.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 8, 2016 at 4:48 PM, Mehdi Amini <span dir="ltr"><<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">LGTM.<br>
<br>
(At this point, I think you should just commit such simple fixes and skip pre-commit review, and keep an eye on the bots)<br>
<div><div class="h5"><br>
> On Aug 8, 2016, at 10:17 AM, Alina Sbirlea <<a href="mailto:asbirlea@google.com">asbirlea@google.com</a>> wrote:<br>
><br>
> asbirlea created this revision.<br>
> asbirlea added a reviewer: MatzeB.<br>
> asbirlea added subscribers: llvm-commits, mehdi_amini.<br>
> Herald added a subscriber: aemerson.<br>
><br>
> In order for the bitcode files to be linked they need to be marked as being cxx language.<br>
> A previous patch renaming the halide runtime failed to do the renaming in the cmake file.<br>
> This should also fix the problem of failing aarch64 tests on green dragon - to be re-enabled after this fix.<br>
><br>
> <a href="https://reviews.llvm.org/D23275" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D23275</a><br>
><br>
> Files:<br>
>  Bitcode/simd_ops/CMakeLists.<wbr>txt<br>
><br>
> Index: Bitcode/simd_ops/CMakeLists.<wbr>txt<br>
> ==============================<wbr>==============================<wbr>=======<br>
> --- Bitcode/simd_ops/CMakeLists.<wbr>txt<br>
> +++ Bitcode/simd_ops/CMakeLists.<wbr>txt<br>
> @@ -3,7 +3,7 @@<br>
> SET_SOURCE_FILES_PROPERTIES(${<wbr>uosources} PROPERTIES LANGUAGE CXX)<br>
> file(GLOB scalar_sources ${CMAKE_CURRENT_SOURCE_DIR}/${<wbr>ARCH}_scalar_tests/*.bc)<br>
> SET_SOURCE_FILES_PROPERTIES(${<wbr>scalar_sources} PROPERTIES LANGUAGE CXX)<br>
> -SET_SOURCE_FILES_PROPERTIES($<wbr>{CMAKE_CURRENT_SOURCE_DIR}/<wbr>simd_op_check_runtime.bc PROPERTIES LANGUAGE CXX)<br>
> +SET_SOURCE_FILES_PROPERTIES($<wbr>{CMAKE_CURRENT_SOURCE_DIR}/${<wbr>ARCH}_halide_runtime.bc PROPERTIES LANGUAGE CXX)<br>
><br>
> list(APPEND LDFLAGS -lpthread -ldl)<br>
> add_library(simd_ops STATIC simd_ops.cpp ${ARCH}_halide_runtime.bc)<br>
><br>
><br>
</div></div>> <D23275.67196.patch><br>
<br>
</blockquote></div><br></div>