<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Sure, I’ll make the change tomorrow. Simon.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 7 Aug 2016, at 20:10, Craig Topper <<a href="mailto:craig.topper@gmail.com" class="">craig.topper@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Can we instead add an assertion here and in getVectorShuffle and fix any code that breaks the rule?<span class=""></span><br class=""><br class="">On Sunday, August 7, 2016, Simon Pilgrim <<a href="mailto:llvm-dev@redking.me.uk" class="">llvm-dev@redking.me.uk</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">No, but we don’t seem to have a hard rule that VECTOR_SHUFFLE can only use (-1) to define undefined mask elements - AFAICT it can be any negative value. This is preventing us from sharing a number of chunks of x86 shuffle matching code that current use Mask[i] < 0 to match all undefineds. <div class=""><br class=""><div class="">Simon.<div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On 7 Aug 2016, at 16:56, Craig Topper <<a href="javascript:_e(%7B%7D,'cvml','craig.topper@gmail.com');" target="_blank" class="">craig.topper@gmail.com</a>> wrote:</div><br class=""><div class="">I don't quite understand this. Does combining come through lowerVectorShuffle? Or when would a VECTOR_SHUFFLE come through where this wasn't true?<span class=""></span><br class=""><br class="">On Sunday, August 7, 2016, Simon Pilgrim via llvm-commits <<a href="javascript:_e(%7B%7D,'cvml','llvm-commits@lists.llvm.org');" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rksimon<br class="">
Date: Sun Aug 7 10:29:12 2016<br class="">
New Revision: 277959<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277959&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject?rev=277959&view=rev</a><br class="">
Log:<br class="">
[X86] lowerVectorShuffle - ensure that undefined mask elements only use SM_SentinelUndef<br class="">
<br class="">
Help lowering and combining (which can specify SM_SentinelZero mask elements) share more shuffle matching code.<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/Target/X86/X86I<wbr class="">SelLowering.cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/Target/X86/X86I<wbr class="">SelLowering.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=277959&r1=277958&r2=277959&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject/llvm/trunk/lib/Target/X8<wbr class="">6/X86ISelLowering.cpp?rev=2779<wbr class="">59&r1=277958&r2=277959&view=<wbr class="">diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/lib/Target/X86/X86I<wbr class="">SelLowering.cpp (original)<br class="">
+++ llvm/trunk/lib/Target/X86/X86I<wbr class="">SelLowering.cpp Sun Aug 7 10:29:12 2016<br class="">
@@ -12281,6 +12281,15 @@ static SDValue lowerVectorShuffle(SDValu<br class="">
return DAG.getVectorShuffle(VT, DL, V1, V2, NewMask);<br class="">
}<br class="">
<br class="">
+ // Ensure that undefined mask elements only use SM_SentinelUndef.<br class="">
+ if (llvm::any_of(Mask, [](int M) { return M < SM_SentinelUndef; })) {<br class="">
+ SmallVector<int, 8> NewMask(Mask.begin(), Mask.end());<br class="">
+ for (int &M : NewMask)<br class="">
+ if (M < SM_SentinelUndef)<br class="">
+ M = SM_SentinelUndef;<br class="">
+ return DAG.getVectorShuffle(VT, DL, V1, V2, NewMask);<br class="">
+ }<br class="">
+<br class="">
// We actually see shuffles that are entirely re-arrangements of a set of<br class="">
// zero inputs. This mostly happens while decomposing complex shuffles into<br class="">
// simple ones. Directly lower these as a buildvector of zeros.<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote><br class=""><br class="">-- <br class="">~Craig<br class="">
</div></blockquote></div><br class=""></div></div></div></div></blockquote><br class=""><br class="">-- <br class="">~Craig<br class="">
</div></blockquote></div><br class=""></div></body></html>