<div dir="ltr">Resubmitted in r277888 = a137e6e2ca7ac4c0ec26e1df33df8cc1f23d8387.  Tested on Linux this time and confirmed that it was broken and that this new patch fixes it.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 5, 2016 at 4:01 PM Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'm not sure why this doesn't break with cl or clang-cl.  In any case, those friend definitions are a pretty ugly hack :-/</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 5, 2016 at 3:28 PM Daniel Berlin <<a href="mailto:dberlin@dberlin.org" target="_blank">dberlin@dberlin.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The friend definitions in DebugMap.h need to be updated now that it's SmallVector and not std::vector</div><div class="gmail_extra"><br><div class="gmail_quote"></div></div><div class="gmail_extra"><div class="gmail_quote">On Fri, Aug 5, 2016 at 3:22 PM, Oleksiy Vyalov via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br></div></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ovyalov added a subscriber: ovyalov.<br>
ovyalov added a comment.<br>
<br>
Looks like this CL broke LLDB cmake buildbot - <a href="http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/17873/steps/ninja%20build%20local/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/17873/steps/ninja%20build%20local/logs/stdio</a>, could you take a look?<br>
<span class="m_-2303401396818511574m_4905126912268749460im m_-2303401396818511574m_4905126912268749460HOEnZb"><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D23213" rel="noreferrer" target="_blank">https://reviews.llvm.org/D23213</a><br>
<br>
<br>
<br>
</span></blockquote></div></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_-2303401396818511574m_4905126912268749460HOEnZb"><div class="m_-2303401396818511574m_4905126912268749460h5">_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div></div></blockquote></div></blockquote></div>