<div dir="ltr">Things still appeared to be failing, so I reverted the fix and the followup in <span style="color:rgb(0,0,0)">r277642.</span></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 3, 2016 at 11:25 AM, David Majnemer via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Aug 3, 2016 at 11:23 AM, Bruno Cardoso Lopes <span dir="ltr"><<a href="mailto:bruno.cardoso@gmail.com" target="_blank">bruno.cardoso@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi David,<br>
<br>
I don't know if this is supposed to fix the same issue in<br>
<a href="http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_build/23319" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_build/23319</a>,<br>
but looks like r277611 is still the culprit here.<br>
<br>
Our internal bots reproduce the same issue and there are only two<br>
commit in the range, r277611 and r277610, but r277610 seems unlikely.<br></blockquote><div><br></div></span><div>I am not sure what is wrong yet but am working on a reduction.  Feel free to revert if this is in your way.</div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks,<br>
<div class="m_-764233090019738921HOEnZb"><div class="m_-764233090019738921h5"><br>
On Wed, Aug 3, 2016 at 10:37 AM, David Majnemer via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: majnemer<br>
> Date: Wed Aug  3 12:37:10 2016<br>
> New Revision: 277614<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277614&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=277614&view=rev</a><br>
> Log:<br>
> [CloneFunction] Don't crash if the value map doesn't hold something<br>
><br>
> It is possible for the value map to not have an entry for some value<br>
> that has already been removed.<br>
><br>
> I don't have a testcase, this is fall-out from a buildbot.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp<br>
><br>
> Modified: llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp?rev=277614&r1=277613&r2=277614&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp?rev=277614&r1=277613&r2=277614&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp Wed Aug  3 12:37:10 2016<br>
> @@ -562,7 +562,7 @@ void llvm::CloneAndPruneIntoFromInst(Fun<br>
>    // Note that we must test the size on each iteration, the worklist can grow.<br>
>    for (unsigned Idx = 0; Idx != Worklist.size(); ++Idx) {<br>
>      const Value *OrigV = Worklist[Idx];<br>
> -    auto *I = cast<Instruction>(VMap.lookup(OrigV));<br>
> +    auto *I = cast_or_null<Instruction>(VMap.lookup(OrigV));<br>
>      if (!I)<br>
>        continue;<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
<br>
<br>
</div></div><span class="m_-764233090019738921HOEnZb"><font color="#888888">--<br>
Bruno Cardoso Lopes<br>
<a href="http://www.brunocardoso.cc" rel="noreferrer" target="_blank">http://www.brunocardoso.cc</a><br>
</font></span></blockquote></div></div></div><br></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>