<div dir="ltr">Sorry, took me a while to figure out why this is generating an error.<div>I was looking to the wrong cause.</div><div><br></div><div>>From this file:</div><div>% \llvm\projects\compiler-rt\lib\interception\tests\CMakeLists.txt<br></div><div><br></div><div>There is that condition:</div><div> if(COMPILER_RT_CAN_EXECUTE_TESTS AND NOT ANDROID AND NOT APPLE)<br></div><div><br></div><div>Which mean the unittest are not activated, and it's causing an empty set of test to run.</div><div>I do not have access to any Apple computer. I'll sync with rnk@ to fix this.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 1, 2016 at 4:51 PM, Etienne Bergeron <span dir="ltr"><<a href="mailto:etienneb@google.com" target="_blank">etienneb@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, I can take a look.<div><br></div><div>There are only unittests to run, and Windows only.</div><div>There are no lit tests for interception.</div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Mon, Aug 1, 2016 at 4:46 PM, Bruno Cardoso Lopes <span dir="ltr"><<a href="mailto:bruno.cardoso@gmail.com" target="_blank">bruno.cardoso@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Etienne,<br>
<br>
This change trigger a warning in some of our public bots (and also<br>
internally), <a href="http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/8686" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/8686</a>:<br>
<br>
lit.py: /Users/buildslave/jenkins/sharedspace/clang-R_master@2/llvm/utils/lit/lit/discovery.py:224:<br>
warning: input '/Users/buildslave/jenkins/sharedspace/clang-R_master@2/clang-build/Build/tools/clang/runtime/compiler-rt-bins/test/interception/Unit'<br>
contained no tests<br>
<br>
I don't see any real tests on the directory, but looks like it's<br>
setting up something from interception/Unit/<a href="http://lit.site.cfg.in" rel="noreferrer" target="_blank">lit.site.cfg.in</a>, is that<br>
right? Can you please take a look into silence this warning?<br>
<br>
Thanks,<br>
<br>
On Wed, Jul 27, 2016 at 8:29 AM, Etienne Bergeron via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: etienneb<br>
> Date: Wed Jul 27 10:29:49 2016<br>
> New Revision: 276881<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=276881&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=276881&view=rev</a><br>
> Log:<br>
> [compiler-rt] Activate interception unittests<br>
><br>
> Summary:<br>
> The unittests recently added were not running when executing 'check-all'.<br>
> Tests are stable on every archictetures and we can now turn them on.<br>
><br>
> Reviewers: rnk<br>
><br>
> Subscribers: llvm-commits, wang0109, chrisha<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D22695" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22695</a><br>
><br>
> Added:<br>
> compiler-rt/trunk/test/interception/CMakeLists.txt<br>
> compiler-rt/trunk/test/interception/Unit/<br>
> compiler-rt/trunk/test/interception/Unit/<a href="http://lit.site.cfg.in" rel="noreferrer" target="_blank">lit.site.cfg.in</a><br>
> Modified:<br>
> compiler-rt/trunk/test/CMakeLists.txt<br>
><br>
> Modified: compiler-rt/trunk/test/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/CMakeLists.txt?rev=276881&r1=276880&r2=276881&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/CMakeLists.txt?rev=276881&r1=276880&r2=276881&view=diff</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/test/CMakeLists.txt (original)<br>
> +++ compiler-rt/trunk/test/CMakeLists.txt Wed Jul 27 10:29:49 2016<br>
> @@ -45,6 +45,9 @@ if(COMPILER_RT_CAN_EXECUTE_TESTS)<br>
> if(COMPILER_RT_HAS_DFSAN)<br>
> add_subdirectory(dfsan)<br>
> endif()<br>
> + if (COMPILER_RT_HAS_INTERCEPTION)<br>
> + add_subdirectory(interception)<br>
> + endif()<br>
> if(COMPILER_RT_HAS_LSAN)<br>
> add_subdirectory(lsan)<br>
> endif()<br>
><br>
> Added: compiler-rt/trunk/test/interception/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/interception/CMakeLists.txt?rev=276881&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/interception/CMakeLists.txt?rev=276881&view=auto</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/test/interception/CMakeLists.txt (added)<br>
> +++ compiler-rt/trunk/test/interception/CMakeLists.txt Wed Jul 27 10:29:49 2016<br>
> @@ -0,0 +1,16 @@<br>
> +set(INTERCEPTION_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})<br>
> +set(INTERCEPTION_TESTSUITES)<br>
> +<br>
> +# Unit tests.<br>
> +if(COMPILER_RT_INCLUDE_TESTS)<br>
> + configure_lit_site_cfg(<br>
> + ${CMAKE_CURRENT_SOURCE_DIR}/Unit/<a href="http://lit.site.cfg.in" rel="noreferrer" target="_blank">lit.site.cfg.in</a><br>
> + ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg)<br>
> + list(APPEND INTERCEPTION_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/Unit)<br>
> + list(APPEND INTERCEPTION_TEST_DEPS InterceptionUnitTests)<br>
> +endif()<br>
> +<br>
> +add_lit_testsuite(check-interception "Running the Interception tests"<br>
> + ${INTERCEPTION_TESTSUITES}<br>
> + DEPENDS ${INTERCEPTION_TEST_DEPS})<br>
> +set_target_properties(check-interception PROPERTIES FOLDER "Compiler-RT Misc")<br>
><br>
> Added: compiler-rt/trunk/test/interception/Unit/<a href="http://lit.site.cfg.in" rel="noreferrer" target="_blank">lit.site.cfg.in</a><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/interception/Unit/lit.site.cfg.in?rev=276881&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/interception/Unit/lit.site.cfg.in?rev=276881&view=auto</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/test/interception/Unit/<a href="http://lit.site.cfg.in" rel="noreferrer" target="_blank">lit.site.cfg.in</a> (added)<br>
> +++ compiler-rt/trunk/test/interception/Unit/<a href="http://lit.site.cfg.in" rel="noreferrer" target="_blank">lit.site.cfg.in</a> Wed Jul 27 10:29:49 2016<br>
> @@ -0,0 +1,14 @@<br>
> +@LIT_SITE_CFG_IN_HEADER@<br>
> +<br>
> +# Load common config for all compiler-rt unit tests.<br>
> +lit_config.load_config(config, "@COMPILER_RT_BINARY_DIR@/unittests/lit.common.unit.configured")<br>
> +<br>
> +# Setup config name.<br>
> +<a href="http://config.name" rel="noreferrer" target="_blank">config.name</a> = 'Interception-Unit'<br>
> +<br>
> +# Setup test source and exec root. For unit tests, we define<br>
> +# it as build directory with interception tests.<br>
> +# FIXME: De-hardcode this path.<br>
> +config.test_exec_root = os.path.join("@COMPILER_RT_BINARY_DIR@", "lib",<br>
> + "interception", "tests")<br>
> +config.test_source_root = config.test_exec_root<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<span class="m_-6651255524651308835HOEnZb"><font color="#888888"><br>
<br>
<br>
--<br>
Bruno Cardoso Lopes<br>
<a href="http://www.brunocardoso.cc" rel="noreferrer" target="_blank">http://www.brunocardoso.cc</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_-6651255524651308835gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Etienne Bergeron<br><div>Chrome</div></div></div></div></div></div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Etienne Bergeron<br><div>Chrome</div></div></div></div></div></div></div>
</div>