<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 28, 2016 at 12:25 PM Zachary Turner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Thu Jul 28 14:18:02 2016<br>
New Revision: 277021<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277021&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=277021&view=rev</a><br>
Log:<br>
[pdb] Fix some warnings that break -Werror builds.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/DebugInfo/Msf/StreamRef.h<br>
    llvm/trunk/lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/DebugInfo/Msf/StreamRef.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/Msf/StreamRef.h?rev=277021&r1=277020&r2=277021&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/Msf/StreamRef.h?rev=277021&r1=277020&r2=277021&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/DebugInfo/Msf/StreamRef.h (original)<br>
+++ llvm/trunk/include/llvm/DebugInfo/Msf/StreamRef.h Thu Jul 28 14:18:02 2016<br>
@@ -17,7 +17,7 @@ namespace llvm {<br>
 namespace msf {<br>
 template <class StreamType, class RefType> class StreamRefBase {<br>
 public:<br>
-  StreamRefBase() : Stream(nullptr), Length(0), ViewOffset(0) {}<br>
+  StreamRefBase() : Stream(nullptr), ViewOffset(0), Length(0) {}<br></blockquote><div><br></div><div>Might just be easier to use non-static data member initializers than trying to keep these in sync with the declaration order? (& then just have a "StreamRefBase() {}" (or "= default" if that works on all our compilers))</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   StreamRefBase(const StreamType &Stream, uint32_t Offset, uint32_t Length)<br>
       : Stream(&Stream), ViewOffset(Offset), Length(Length) {}<br>
<br>
<br>
Modified: llvm/trunk/lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp?rev=277021&r1=277020&r2=277021&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp?rev=277021&r1=277020&r2=277021&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp (original)<br>
+++ llvm/trunk/lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp Thu Jul 28 14:18:02 2016<br>
@@ -198,9 +198,9 @@ Error DbiStreamBuilder::finalize() {<br>
   DbiStreamHeader *H = Allocator.Allocate<DbiStreamHeader>();<br>
<br>
   if (auto EC = generateModiSubstream())<br>
-    return std::move(EC);<br>
+    return EC;<br>
   if (auto EC = generateFileInfoSubstream())<br>
-    return std::move(EC);<br>
+    return EC;<br>
<br>
   H->VersionHeader = *VerHeader;<br>
   H->VersionSignature = -1;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>