<div dir="ltr"><div>The reason "Should be committed as one CL." is on the commit message.</div><div>I agree that reply to original commits could be helpful.</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 28, 2016 at 5:29 PM Davide Italiano <<a href="mailto:davide@freebsd.org">davide@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Jul 28, 2016 at 5:18 PM, Vitaly Buka via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> By mistake I committed several temporarily git CLs from my local branch. It<br>
> is already reverted.<br>
><br>
<br>
When a commit is reverted, the commit that reverts should mention the<br>
revision reverted (I might have missed it, but I don't see it), e.g.<br>
"Revert r6666666 because it breaks the bots).<br>
You can also (or in alternative) reply to your original commit saying<br>
that this was reverted so that people don't have to search through the<br>
lists.<br>
<br>
--<br>
Davide<br>
<br>
><br>
> On Thu, Jul 28, 2016 at 5:14 PM David Majnemer <<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>><br>
> wrote:<br>
>><br>
>> This commit message isn't very enlightening.  What's going on?<br>
>> Please strive for commit messages which are more descriptive.<br>
>><br>
>> On Thu, Jul 28, 2016 at 6:50 PM, Vitaly Buka via llvm-commits<br>
>> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>>><br>
>>> Author: vitalybuka<br>
>>> Date: Thu Jul 28 17:50:43 2016<br>
>>> New Revision: 277066<br>
>>><br>
>>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277066&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=277066&view=rev</a><br>
>>> Log:<br>
>>> range<br>
>>><br>
>>> Modified:<br>
>>>     llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp<br>
>>><br>
>>> Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp<br>
>>> URL:<br>
>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp?rev=277066&r1=277065&r2=277066&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp?rev=277066&r1=277065&r2=277066&view=diff</a><br>
>>><br>
>>> ==============================================================================<br>
>>> --- llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp (original)<br>
>>> +++ llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp Thu Jul 28<br>
>>> 17:50:43 2016<br>
>>> @@ -30,6 +30,8 @@ using namespace PatternMatch;<br>
>>><br>
>>>  STATISTIC(NumSimplified, "Number of library calls simplified");<br>
>>><br>
>>> +extern cl::opt<bool> ClUseAfterScope;<br>
>>> +<br>
>>>  /// Return the specified type promoted as it would be to pass though a<br>
>>> va_arg<br>
>>>  /// area.<br>
>>>  static Type *getPromotedType(Type *Ty) {<br>
>>> @@ -1209,6 +1211,10 @@ static bool removeTriviallyEmptyRange(In<br>
>>>                                        unsigned EndID, InstCombiner &IC)<br>
>>> {<br>
>>>    assert(I.getIntrinsicID() == StartID &&<br>
>>>           "Start intrinsic does not have expected ID");<br>
>>> +  // Even if the range is empty asan need to poison memory to detect<br>
>>> invalid<br>
>>> +  // access latter.<br>
>>> +  if (ClUseAfterScope)<br>
>>> +    return false;<br>
>>>    BasicBlock::iterator BI(I), BE(I.getParent()->end());<br>
>>>    for (++BI; BI != BE; ++BI) {<br>
>>>      if (auto *E = dyn_cast<IntrinsicInst>(BI)) {<br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> llvm-commits mailing list<br>
>>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
>><br>
>><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</blockquote></div>