Yes.<br><br>On Friday, July 29, 2016, Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Should we merge this to 3.9?<br>
<br>
Thanks,<br>
Hans<br>
<br>
On Thu, Jul 28, 2016 at 10:39 PM, David Majnemer via llvm-commits<br>
<<a href="javascript:;" onclick="_e(event, 'cvml', 'llvm-commits@lists.llvm.org')">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: majnemer<br>
> Date: Fri Jul 29 00:39:21 2016<br>
> New Revision: 277114<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277114&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=277114&view=rev</a><br>
> Log:<br>
> [EarlyCSE] Correctly handle simplified, but live, instructions<br>
><br>
> Some instructions may have their uses replaced with a symbolic constant.<br>
> However, the instruction may still have side effects which percludes it<br>
> from being removed from the function.  EarlyCSE treated such an<br>
> instruction as if it were removed, resulting in PR28763.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp<br>
>     llvm/trunk/test/Transforms/EarlyCSE/basic.ll<br>
><br>
> Modified: llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp?rev=277114&r1=277113&r2=277114&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp?rev=277114&r1=277113&r2=277114&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/Scalar/EarlyCSE.cpp Fri Jul 29 00:39:21 2016<br>
> @@ -582,6 +582,7 @@ bool EarlyCSE::processNode(DomTreeNode *<br>
>      // its simpler value.<br>
>      if (Value *V = SimplifyInstruction(Inst, DL, &TLI, &DT, &AC)) {<br>
>        DEBUG(dbgs() << "EarlyCSE Simplify: " << *Inst << "  to: " << *V << '\n');<br>
> +      bool Killed = false;<br>
>        if (!Inst->use_empty()) {<br>
>          Inst->replaceAllUsesWith(V);<br>
>          Changed = true;<br>
> @@ -589,11 +590,12 @@ bool EarlyCSE::processNode(DomTreeNode *<br>
>        if (isInstructionTriviallyDead(Inst, &TLI)) {<br>
>          Inst->eraseFromParent();<br>
>          Changed = true;<br>
> +        Killed = true;<br>
>        }<br>
> -      if (Changed) {<br>
> +      if (Changed)<br>
>          ++NumSimplify;<br>
> +      if (Killed)<br>
>          continue;<br>
> -      }<br>
>      }<br>
><br>
>      // If this is a simple instruction that we can value number, process it.<br>
><br>
> Modified: llvm/trunk/test/Transforms/EarlyCSE/basic.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/EarlyCSE/basic.ll?rev=277114&r1=277113&r2=277114&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/EarlyCSE/basic.ll?rev=277114&r1=277113&r2=277114&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/EarlyCSE/basic.ll (original)<br>
> +++ llvm/trunk/test/Transforms/EarlyCSE/basic.ll Fri Jul 29 00:39:21 2016<br>
> @@ -276,3 +276,17 @@ define void @dse_neg2(i32 *%P) {<br>
>    ret void<br>
>  }<br>
><br>
> +@c = external global i32, align 4<br>
> +declare i32 @reads_c(i32 returned)<br>
> +define void @pr28763() {<br>
> +entry:<br>
> +; CHECK-LABEL: @pr28763(<br>
> +; CHECK: store i32 0, i32* @c, align 4<br>
> +; CHECK: call i32 @reads_c(i32 0)<br>
> +; CHECK: store i32 2, i32* @c, align 4<br>
> +  %load = load i32, i32* @c, align 4<br>
> +  store i32 0, i32* @c, align 4<br>
> +  %call = call i32 @reads_c(i32 0)<br>
> +  store i32 2, i32* @c, align 4<br>
> +  ret void<br>
> +}<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="javascript:;" onclick="_e(event, 'cvml', 'llvm-commits@lists.llvm.org')">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>