<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jul 28, 2016 at 3:01 PM, George Rimar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grimar<br>
Date: Thu Jul 28 17:01:56 2016<br>
New Revision: 277043<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277043&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=277043&view=rev</a><br>
Log:<br>
[ELF] - Cosmetic change. NFC.<br>
<br>
peek()[0] == '*' changed to peek().startswith("*")<br></blockquote><div><br></div><div>It's actually more than that. You can now remove `!peek().empty()` check.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    lld/trunk/ELF/LinkerScript.cpp<br>
<br>
Modified: lld/trunk/ELF/LinkerScript.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=277043&r1=277042&r2=277043&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=277043&r1=277042&r2=277043&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/LinkerScript.cpp (original)<br>
+++ lld/trunk/ELF/LinkerScript.cpp Thu Jul 28 17:01:56 2016<br>
@@ -747,7 +747,7 @@ void ScriptParser::readOutputSectionDesc<br>
   expect("{");<br>
<br>
   while (!Error && !skip("}")) {<br>
-    if ((!peek().empty() && peek()[0] == '*') || peek() == "KEEP") {<br>
+    if ((!peek().empty() && peek().startswith("*")) || peek() == "KEEP") {<br>
       Cmd->Commands.push_back(readInputSectionDescription());<br>
       continue;<br>
     }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>