<div dir="ltr">Thanks to report this.<div>I'm gonna take a look to this.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jul 23, 2016 at 9:49 PM, Bruno Cardoso Lopes <span dir="ltr"><<a href="mailto:bruno.cardoso@gmail.com" target="_blank">bruno.cardoso@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Etienne,<br>
<br>
On Thu, Jul 21, 2016 at 12:49 PM, Etienne Bergeron via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: etienneb<br>
> Date: Thu Jul 21 14:49:11 2016<br>
> New Revision: 276324<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=276324&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=276324&view=rev</a><br>
> Log:<br>
> [compiler-rt] Fix interception of memcpy/memmove on win64<br>
><br>
> Summary:<br>
> This patch is fixing running interception unittests for memcpy/memmove on<br>
> windows 64.<br>
><br>
> Reviewers: rnk<br>
><br>
> Subscribers: llvm-commits, wang0109, kubabrecka, chrisha<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D22641" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22641</a><br>
><br>
> Modified:<br>
>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc<br>
>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_interceptors.h<br>
>     compiler-rt/trunk/test/asan/TestCases/Windows/intercept_memcpy.cc<br>
><br>
> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc?rev=276324&r1=276323&r2=276324&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc?rev=276324&r1=276323&r2=276324&view=diff</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc (original)<br>
> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc Thu Jul 21 14:49:11 2016<br>
> @@ -663,7 +663,12 @@ INTERCEPTOR(void*, memchr, const void *s<br>
>      return internal_memchr(s, c, n);<br>
>    void *ctx;<br>
>    COMMON_INTERCEPTOR_ENTER(ctx, memchr, s, c, n);<br>
> -  void *res = REAL(memchr)(s, c, n);<br>
> +  void *res;<br>
> +  if (REAL(memchr)) {<br>
<br>
This is causing a warning when using recent clang (which I tried to<br>
fix but failed in r276539). Since you are more familiar with the code<br>
in question, can you fix it? :-)<br>
<br>
Thanks,<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Bruno Cardoso Lopes<br>
<a href="http://www.brunocardoso.cc" rel="noreferrer" target="_blank">http://www.brunocardoso.cc</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Etienne Bergeron<br><div>Chrome</div></div></div></div></div></div></div>
</div>