<div dir="ltr">also, AFAICT, the change was not code reviewed. (please correct me if I am wrong) <div>and it it were, I wouldn't like it. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jul 23, 2016 at 6:27 PM, Bruno Cardoso Lopes via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: bruno<br>
Date: Sat Jul 23 20:27:07 2016<br>
New Revision: 276541<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=276541&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=276541&view=rev</a><br>
Log:<br>
Revert r276539 "Silence -Wpointer-bool-conversion warning after r276324"<br>
<br>
Some bots are not happy with the change.<br>
This reverts commit d307ca28083065851ad969444f3c063562f2d4bd.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc?rev=276541&r1=276540&r2=276541&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc?rev=276541&r1=276540&r2=276541&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc Sat Jul 23 20:27:07 2016<br>
@@ -664,7 +664,7 @@ INTERCEPTOR(void*, memchr, const void *s<br>
   void *ctx;<br>
   COMMON_INTERCEPTOR_ENTER(ctx, memchr, s, c, n);<br>
   void *res;<br>
-  if (REAL(&memchr)) {<br>
+  if (REAL(memchr)) {<br>
     res = REAL(memchr)(s, c, n);<br>
   } else {<br>
     res = internal_memchr(s, c, n);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>