<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><div style="direction: inherit;">r268977 shouldn't impact your build at all without changing your builder configuration. The change is to allow lib/builtins/CMakelists.txt to be treated as a top-level CMake project for the builtin libraries. If you don't use the builtins directory as the root of the CMake invocation it should have no impact on the build.</div><div style="direction: inherit;"><br></div><div style="direction: inherit;">I'm OOO until Monday, and don't have hardware to reproduce. Can you reproduce it locally? If so can we try and sync up next week to debug better? I'd really like to understand why you're getting false success.</div><div style="direction: inherit;"><br></div><div style="direction: inherit;">Thanks,</div>-Chris</div><div><br>On Jul 22, 2016, at 8:46 AM, Daniel Sanders <<a href="mailto:Daniel.Sanders@imgtec.com">Daniel.Sanders@imgtec.com</a>> wrote:<br><br></div><blockquote type="cite"><div><blockquote type="cite"><span>This attempt at fixing it didn't work so I've already reverted it and manually</span><br></blockquote><blockquote type="cite"><span>set CAN_TARGET_mips64=FALSE instead. This should get us back to the</span><br></blockquote><blockquote type="cite"><span>position we were in before the reboot but it will only last until the next time</span><br></blockquote><blockquote type="cite"><span>it fully reconfigures.</span><br></blockquote><span></span><br><span>This workaround didn't work either because cmake re-calculates it on each invocation but I've fixed that in r276402.</span><br><span></span><br><blockquote type="cite"><span>-----Original Message-----</span><br></blockquote><blockquote type="cite"><span>From: Daniel Sanders</span><br></blockquote><blockquote type="cite"><span>Sent: 21 July 2016 11:06</span><br></blockquote><blockquote type="cite"><span>To: Daniel Sanders; <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>; Chris Bieneman</span><br></blockquote><blockquote type="cite"><span>(<a href="mailto:beanz@apple.com">beanz@apple.com</a>); Vasileios Kalintiris</span><br></blockquote><blockquote type="cite"><span>Subject: RE: [compiler-rt] r276256 - Attempt to fix clang-cmake-mips after</span><br></blockquote><blockquote type="cite"><span>r268977.</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Hi Chris,</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Vasileios and I rebooted one of our buildslaves yesterday to fix some disk</span><br></blockquote><blockquote type="cite"><span>errors and when we brought it back up we found that compiler-rt is failing</span><br></blockquote><blockquote type="cite"><span>some mips64 tests. However, these tests weren't enabled before. I think it</span><br></blockquote><blockquote type="cite"><span>has wiped out the build area and fully-reconfigured and this has caused it to</span><br></blockquote><blockquote type="cite"><span>notice the changes in r268977 and set CAN_TARGET_mips64=TRUE. It used to</span><br></blockquote><blockquote type="cite"><span>be false because it's the linker cannot find the multilibs (they're not</span><br></blockquote><blockquote type="cite"><span>installed).</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>This attempt at fixing it didn't work so I've already reverted it and manually</span><br></blockquote><blockquote type="cite"><span>set CAN_TARGET_mips64=FALSE instead. This should get us back to the</span><br></blockquote><blockquote type="cite"><span>position we were in before the reboot but it will only last until the next time</span><br></blockquote><blockquote type="cite"><span>it fully reconfigures.</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Do you have any suggestions for fixing this properly?</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><blockquote type="cite"><span>-----Original Message-----</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>From: llvm-commits [<a href="mailto:llvm-commits-bounces@lists.llvm.org">mailto:llvm-commits-bounces@lists.llvm.org</a>] On</span><br></blockquote></blockquote><blockquote type="cite"><span>Behalf</span><br></blockquote><blockquote type="cite"><blockquote type="cite"><span>Of Daniel Sanders via llvm-commits</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Sent: 21 July 2016 10:28</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>To: <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Subject: [compiler-rt] r276256 - Attempt to fix clang-cmake-mips after</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>r268977.</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Author: dsanders</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Date: Thu Jul 21 04:28:09 2016</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>New Revision: 276256</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=276256&view=rev">http://llvm.org/viewvc/llvm-project?rev=276256&view=rev</a></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Log:</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Attempt to fix clang-cmake-mips after r268977.</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>I think it's wiped out the build area and fully-reconfigured for the first time</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>since r268977. This seems to have caused Mips64 to become enabled when</span><br></blockquote></blockquote><blockquote type="cite"><span>it</span><br></blockquote><blockquote type="cite"><blockquote type="cite"><span>wasn't</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>before because compiling with -mabi=64 succeeds but linking with -</span><br></blockquote></blockquote><blockquote type="cite"><span>mabi=64</span><br></blockquote><blockquote type="cite"><blockquote type="cite"><span>fails.</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Modified:</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span> compiler-rt/trunk/cmake/builtin-config-ix.cmake</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>Modified: compiler-rt/trunk/cmake/builtin-config-ix.cmake</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/builtin-">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/builtin-</a></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>config-ix.cmake?rev=276256&r1=276255&r2=276256&view=diff</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><span>==========================================================</span><br></blockquote><blockquote type="cite"><blockquote type="cite"><span>====================</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>--- compiler-rt/trunk/cmake/builtin-config-ix.cmake (original)</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>+++ compiler-rt/trunk/cmake/builtin-config-ix.cmake Thu Jul 21 04:28:09</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>2016</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>@@ -2,6 +2,12 @@ include(BuiltinTests)</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span> # Make all the tests only check the compiler</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span> set(TEST_COMPILE_ONLY On)</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>+# Temporary fix for Mips buildbots this broke. It's the linker that rejects</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>+# inappropriate multilibs on this system.</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>+check_compile_definition("__mips__" "" IS_MIPS_HOST)</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>+if(IS_MIPS_HOST)</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>+ set(TEST_COMPILE_ONLY OFF)</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>+endif()</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span> builtin_check_c_compiler_flag(-fPIC</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>COMPILER_RT_HAS_FPIC_FLAG)</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span> builtin_check_c_compiler_flag(-fPIE</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>COMPILER_RT_HAS_FPIE_FLAG)</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>_______________________________________________</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span>llvm-commits mailing list</span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span><a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a></span><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><span><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></span><br></blockquote></blockquote></div></blockquote></body></html>