<div dir="ltr">r276337 -- thanks for the approval!<div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 21, 2016 at 1:49 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sounds good to me.<br>
<br>
George, go ahead and commit to the branch, or let me know if you'd let<br>
me to do it.<br>
<br>
Thanks,<br>
Hans<br>
<div><div><br>
On Wed, Jul 20, 2016 at 8:45 PM, Daniel Berlin <<a href="mailto:dberlin@dberlin.org" target="_blank">dberlin@dberlin.org</a>> wrote:<br>
> Yeah, it was actually an assert i was using to make sure the code wasn't<br>
> doing something broken on "normal" code while debugging the walker (it would<br>
> occasionally infinite loop or do silly things when i first started writing<br>
> it, and this was the easiest way to bugpoint things :P)<br>
> It should not be there for real, as it is definitely possible to have cases<br>
> where it is valid to visit > 1000 times.<br>
><br>
><br>
> On Wed, Jul 20, 2016 at 5:05 PM, George Burgess IV via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Hi Hans,<br>
>><br>
>> Can we please apply the attached patch to the 3.9 branch? It fixes<br>
>> PR28632, which is a release blocker.<br>
>><br>
>> It doesn't apply to trunk, because we entirely replaced the piece of code<br>
>> that this patch "fixes" in r275940.<br>
>><br>
>> (I realize that fixing an assertion failure by removing the assertion<br>
>> looks kind of bad, but said assertion was really more of a warning that<br>
>> we've hit a pathological-ish case than an error. ;) )<br>
>><br>
>> Thank you!<br>
>> George<br>
</div></div></blockquote></div><br></div></div>