<div dir="ltr">On first look I see asm only in *.cc files, all *.c files have __asm__<br><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 18, 2016 at 2:04 PM Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" class="cremed">echristo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ok, thanks. Please follow up when you have something.</div><div dir="ltr"><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 18, 2016 at 2:00 PM Vitaly Buka <<a href="mailto:vitalybuka@google.com" target="_blank" class="cremed">vitalybuka@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">No, not yet. </div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 18, 2016 at 1:23 PM Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" class="cremed">echristo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Vitaly: Have you figured out what was going on here? The lack of consistency among all of the files is concerning and I'm not seeing the failure at build time myself which makes it difficult to ensure before check-in.<div><br></div><div>Thanks.</div><div><br></div><div></div></div><div dir="ltr"><div>-eric</div></div><div dir="ltr"><div><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 15, 2016 at 4:14 PM Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" class="cremed">echristo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This is particularly weird as compiler-rt is inconsistent with whether or not we use __asm__, __asm, or asm in a bunch of files that we'll definitely build for asan (sanitizer_syscall_linux_x86_64.inc for example).<div><br></div><div>We can change it to __asm__ but I'd like to know why this isn't showing up otherwise.</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 15, 2016 at 4:03 PM Vitaly Buka <<a href="mailto:vitalybuka@google.com" target="_blank" class="cremed">vitalybuka@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><pre style="font-family:"courier new",courier,monotype,monospace;font-size:medium;line-height:normal"><pre style="font-family:"courier new",courier,monotype,monospace"><span class="m_-743306908881143060m_7112019080715934493m_-9090008993390294236m_-4168214136333696790m_-3781828751169158730m_48885358619404941inbox-inbox-stdout">-DLLVM_ENABLE_WERROR=ON is set on here bot. I don't see this on general bots.</span></pre></pre></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 15, 2016 at 3:54 PM Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" class="cremed">echristo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Huh, does the sanitizer bot have different warnings options? Perhaps we could turn it on in general?</div><div dir="ltr"><div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 15, 2016 at 3:37 PM Vitaly Buka <<a href="mailto:vitalybuka@google.com" target="_blank" class="cremed">vitalybuka@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vitalybuka added a subscriber: vitalybuka.<br>
vitalybuka added a comment.<br>
<br>
The patch introduced this: <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/24764/steps/build%20with%20ninja/logs/stdio" rel="noreferrer" target="_blank" class="cremed">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/24764/steps/build%20with%20ninja/logs/stdio</a><br>
<br>
FAILED: /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/clang_build/bin/clang -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iprojects/compiler-rt/lib/builtins -I/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/lib/builtins -Iinclude -I/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/include -gmlt -fPIC -Wall -W -Wno-unused-parameter -Wwrite-strings -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wdelete-non-virtual-dtor -Werror -Werror=date-time -fcolor-diagnostics -ffunction-sections -fdata-sections -Wall -Werror -Wno-unused-parameter -O3 -UNDEBUG -m32 -std=gnu99 -MMD -MT projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.builtins-i386.dir/cpu_model.c.o -MF projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.builtins-i386.dir/cpu_model.c.o.d -o projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.builtins-i386.dir/cpu_model.c.o -c /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/lib/builtins/cpu_model.c<br>
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/lib/builtins/cpu_model.c:174:3: error: extension used [-Werror,-Wlanguage-extension-token]<br>
<br>
asm("movl\t%%ebx, %%esi\n\t"<br>
^<br>
<br>
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/lib/builtins/cpu_model.c:224:3: error: extension used [-Werror,-Wlanguage-extension-token]<br>
<br>
asm("movl\t%%ebx, %%esi\n\t"<br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D22181" rel="noreferrer" target="_blank" class="cremed">https://reviews.llvm.org/D22181</a><br>
<br>
<br>
<br>
</blockquote></div></div></div></blockquote></div>
</blockquote></div></blockquote></div></div></div></blockquote></div>
</blockquote></div>
</blockquote></div></div>