<div dir="ltr">Nice catch! Thanks Justin.<div><br></div><div>- Lang.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 13, 2016 at 11:27 AM, Justin Lebar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jlebar<br>
Date: Wed Jul 13 13:27:49 2016<br>
New Revision: 275293<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=275293&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=275293&view=rev</a><br>
Log:<br>
Fix warning in ObjectTransformLayerTest.<br>
<br>
Doing "I++" inside of an EXPECT_* triggers<br>
<br>
  warning: expression with side effects has no effect in an unevaluated context<br>
<br>
because EXPECT_* partially expands to<br>
<br>
  EqHelper<(sizeof(::testing::internal::IsNullLiteralHelper(MockObjects[I++] + 1)) == 1)><br>
<br>
which is an unevaluated context.<br>
<br>
Modified:<br>
    llvm/trunk/unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp<br>
<br>
Modified: llvm/trunk/unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp?rev=275293&r1=275292&r2=275293&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp?rev=275293&r1=275292&r2=275293&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp (original)<br>
+++ llvm/trunk/unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp Wed Jul 13 13:27:49 2016<br>
@@ -62,7 +62,8 @@ public:<br>
     EXPECT_EQ(MockResolver, *Resolver) << "Resolver should pass through";<br>
     size_t I = 0;<br>
     for (auto &ObjPtr : Objects) {<br>
-      EXPECT_EQ(MockObjects[I++] + 1, *ObjPtr) << "Transform should be applied";<br>
+      EXPECT_EQ(MockObjects[I] + 1, *ObjPtr) << "Transform should be applied";<br>
+      I++;<br>
     }<br>
     EXPECT_EQ(MockObjects.size(), I) << "Number of objects should match";<br>
     LastCalled = "addObjectSet";<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>