<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sat, Jul 9, 2016 at 2:14 PM, Saleem Abdulrasool via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: compnerd<br>
Date: Sat Jul  9 16:14:36 2016<br>
New Revision: 274989<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=274989&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=274989&view=rev</a><br>
Log:<br>
test: Use %clangxx in objc++ test files<br>
<br>
These test in this change are objc++, but are built using %clang, not %clangxx.<br>
The reason this works is the driver has been adding -lc++ for sanitizer enabled<br>
builds. By making these tests use %clangxx, they no longer depend on the driver<br>
linking to c++.  Doing so will allow us to prevent overlinking of libc++ for<br>
applications.<br></blockquote><div><br></div><div>Oops.  Forgot to mention: Patch by Dave Lee.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Modified:<br>
    compiler-rt/trunk/test/asan/TestCases/Darwin/<a href="http://address-range-limit.mm" rel="noreferrer" target="_blank">address-range-limit.mm</a><br>
    compiler-rt/trunk/test/tsan/Darwin/<a href="http://gcd-blocks.mm" rel="noreferrer" target="_blank">gcd-blocks.mm</a><br>
    compiler-rt/trunk/test/tsan/Darwin/<a href="http://gcd-groups-destructor.mm" rel="noreferrer" target="_blank">gcd-groups-destructor.mm</a><br>
    compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr-recursive.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr-recursive.mm</a><br>
    compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr-stress.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr-stress.mm</a><br>
    compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr.mm</a><br>
    compiler-rt/trunk/test/tsan/Darwin/<a href="http://osatomics-add.mm" rel="noreferrer" target="_blank">osatomics-add.mm</a><br>
    compiler-rt/trunk/test/tsan/Darwin/<a href="http://osatomics-list.mm" rel="noreferrer" target="_blank">osatomics-list.mm</a><br>
<br>
Modified: compiler-rt/trunk/test/asan/TestCases/Darwin/<a href="http://address-range-limit.mm" rel="noreferrer" target="_blank">address-range-limit.mm</a><br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Darwin/address-range-limit.mm?rev=274989&r1=274988&r2=274989&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Darwin/address-range-limit.mm?rev=274989&r1=274988&r2=274989&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/asan/TestCases/Darwin/<a href="http://address-range-limit.mm" rel="noreferrer" target="_blank">address-range-limit.mm</a> (original)<br>
+++ compiler-rt/trunk/test/asan/TestCases/Darwin/<a href="http://address-range-limit.mm" rel="noreferrer" target="_blank">address-range-limit.mm</a> Sat Jul  9 16:14:36 2016<br>
@@ -1,7 +1,7 @@<br>
 // Regression test for <a href="https://code.google.com/p/address-sanitizer/issues/detail?id=368" rel="noreferrer" target="_blank">https://code.google.com/p/address-sanitizer/issues/detail?id=368</a>.<br>
<br>
-// RUN: %clang_asan %s -Wno-deprecated-declarations -flat_namespace -bundle -undefined suppress -o %t.bundle<br>
-// RUN: %clang_asan %s -Wno-deprecated-declarations -o %t -framework Foundation && not %run %t 2>&1 | FileCheck %s<br>
+// RUN: %clangxx_asan %s -Wno-deprecated-declarations -flat_namespace -bundle -undefined suppress -o %t.bundle<br>
+// RUN: %clangxx_asan %s -Wno-deprecated-declarations -o %t -framework Foundation && not %run %t 2>&1 | FileCheck %s<br>
<br>
 #import <Foundation/Foundation.h><br>
 #import <mach-o/dyld.h><br>
<br>
Modified: compiler-rt/trunk/test/tsan/Darwin/<a href="http://gcd-blocks.mm" rel="noreferrer" target="_blank">gcd-blocks.mm</a><br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/gcd-blocks.mm?rev=274989&r1=274988&r2=274989&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/gcd-blocks.mm?rev=274989&r1=274988&r2=274989&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/tsan/Darwin/<a href="http://gcd-blocks.mm" rel="noreferrer" target="_blank">gcd-blocks.mm</a> (original)<br>
+++ compiler-rt/trunk/test/tsan/Darwin/<a href="http://gcd-blocks.mm" rel="noreferrer" target="_blank">gcd-blocks.mm</a> Sat Jul  9 16:14:36 2016<br>
@@ -1,4 +1,4 @@<br>
-// RUN: %clang_tsan %s -o %t -framework Foundation<br>
+// RUN: %clangxx_tsan %s -o %t -framework Foundation<br>
 // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s<br>
<br>
 #import <Foundation/Foundation.h><br>
<br>
Modified: compiler-rt/trunk/test/tsan/Darwin/<a href="http://gcd-groups-destructor.mm" rel="noreferrer" target="_blank">gcd-groups-destructor.mm</a><br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/gcd-groups-destructor.mm?rev=274989&r1=274988&r2=274989&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/gcd-groups-destructor.mm?rev=274989&r1=274988&r2=274989&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/tsan/Darwin/<a href="http://gcd-groups-destructor.mm" rel="noreferrer" target="_blank">gcd-groups-destructor.mm</a> (original)<br>
+++ compiler-rt/trunk/test/tsan/Darwin/<a href="http://gcd-groups-destructor.mm" rel="noreferrer" target="_blank">gcd-groups-destructor.mm</a> Sat Jul  9 16:14:36 2016<br>
@@ -1,4 +1,4 @@<br>
-// RUN: %clang_tsan %s -o %t -framework Foundation<br>
+// RUN: %clangxx_tsan %s -o %t -framework Foundation<br>
 // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s<br>
<br>
 #import <Foundation/Foundation.h><br>
<br>
Modified: compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr-recursive.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr-recursive.mm</a><br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/libcxx-shared-ptr-recursive.mm?rev=274989&r1=274988&r2=274989&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/libcxx-shared-ptr-recursive.mm?rev=274989&r1=274988&r2=274989&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr-recursive.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr-recursive.mm</a> (original)<br>
+++ compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr-recursive.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr-recursive.mm</a> Sat Jul  9 16:14:36 2016<br>
@@ -1,4 +1,4 @@<br>
-// RUN: %clang_tsan %s -o %t -framework Foundation<br>
+// RUN: %clangxx_tsan %s -o %t -framework Foundation<br>
 // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s<br>
<br>
 #import <Foundation/Foundation.h><br>
<br>
Modified: compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr-stress.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr-stress.mm</a><br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/libcxx-shared-ptr-stress.mm?rev=274989&r1=274988&r2=274989&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/libcxx-shared-ptr-stress.mm?rev=274989&r1=274988&r2=274989&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr-stress.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr-stress.mm</a> (original)<br>
+++ compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr-stress.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr-stress.mm</a> Sat Jul  9 16:14:36 2016<br>
@@ -1,4 +1,4 @@<br>
-// RUN: %clang_tsan %s -o %t -framework Foundation<br>
+// RUN: %clangxx_tsan %s -o %t -framework Foundation<br>
 // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s<br>
<br>
 #import <Foundation/Foundation.h><br>
<br>
Modified: compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr.mm</a><br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/libcxx-shared-ptr.mm?rev=274989&r1=274988&r2=274989&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/libcxx-shared-ptr.mm?rev=274989&r1=274988&r2=274989&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr.mm</a> (original)<br>
+++ compiler-rt/trunk/test/tsan/Darwin/<a href="http://libcxx-shared-ptr.mm" rel="noreferrer" target="_blank">libcxx-shared-ptr.mm</a> Sat Jul  9 16:14:36 2016<br>
@@ -1,4 +1,4 @@<br>
-// RUN: %clang_tsan %s -o %t -framework Foundation<br>
+// RUN: %clangxx_tsan %s -o %t -framework Foundation<br>
 // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s<br>
<br>
 #import <Foundation/Foundation.h><br>
<br>
Modified: compiler-rt/trunk/test/tsan/Darwin/<a href="http://osatomics-add.mm" rel="noreferrer" target="_blank">osatomics-add.mm</a><br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/osatomics-add.mm?rev=274989&r1=274988&r2=274989&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/osatomics-add.mm?rev=274989&r1=274988&r2=274989&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/tsan/Darwin/<a href="http://osatomics-add.mm" rel="noreferrer" target="_blank">osatomics-add.mm</a> (original)<br>
+++ compiler-rt/trunk/test/tsan/Darwin/<a href="http://osatomics-add.mm" rel="noreferrer" target="_blank">osatomics-add.mm</a> Sat Jul  9 16:14:36 2016<br>
@@ -1,4 +1,4 @@<br>
-// RUN: %clang_tsan %s -o %t -framework Foundation -std=c++11<br>
+// RUN: %clangxx_tsan %s -o %t -framework Foundation -std=c++11<br>
 // RUN: %run %t 2>&1 | FileCheck %s<br>
<br>
 #import <Foundation/Foundation.h><br>
<br>
Modified: compiler-rt/trunk/test/tsan/Darwin/<a href="http://osatomics-list.mm" rel="noreferrer" target="_blank">osatomics-list.mm</a><br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/osatomics-list.mm?rev=274989&r1=274988&r2=274989&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/osatomics-list.mm?rev=274989&r1=274988&r2=274989&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/tsan/Darwin/<a href="http://osatomics-list.mm" rel="noreferrer" target="_blank">osatomics-list.mm</a> (original)<br>
+++ compiler-rt/trunk/test/tsan/Darwin/<a href="http://osatomics-list.mm" rel="noreferrer" target="_blank">osatomics-list.mm</a> Sat Jul  9 16:14:36 2016<br>
@@ -1,4 +1,4 @@<br>
-// RUN: %clang_tsan %s -o %t -framework Foundation -std=c++11<br>
+// RUN: %clangxx_tsan %s -o %t -framework Foundation -std=c++11<br>
 // RUN: %run %t 2>&1 | FileCheck %s<br>
<br>
 #import <Foundation/Foundation.h><br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>