<div dir="ltr"><div>Thanks for the heads-up!</div><div><br></div>Looks like a 'const' got dropped when it shouldn't have been. Let's see if r274961 fixes the issue. :)<div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 8, 2016 at 11:19 PM, Davide Italiano <span dir="ltr"><<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>On Fri, Jul 8, 2016 at 7:54 PM, George Burgess IV via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: gbiv<br>
> Date: Fri Jul 8 21:54:42 2016<br>
> New Revision: 274958<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=274958&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=274958&view=rev</a><br>
> Log:<br>
> [CFLAA] Move the graph builder out from CFLSteens. NFC.<br>
><br>
> Patch by Jia Chen.<br>
><br>
> Differential Revision: <a href="http://reviews.llvm.org/D22022" rel="noreferrer" target="_blank">http://reviews.llvm.org/D22022</a><br>
><br>
> Modified:<br>
> llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h<br>
> llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h<br>
> llvm/trunk/lib/Analysis/AliasAnalysisSummary.h<br>
> llvm/trunk/lib/Analysis/CFLGraph.h<br>
> llvm/trunk/lib/Analysis/CFLSteensAliasAnalysis.cpp<br>
><br>
> Modified: llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h?rev=274958&r1=274957&r2=274958&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h?rev=274958&r1=274957&r2=274958&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h (original)<br>
> +++ llvm/trunk/include/llvm/Analysis/CFLAndersAliasAnalysis.h Fri Jul 8 21:54:42 2016<br>
> @@ -21,12 +21,23 @@<br>
><br>
> namespace llvm {<br>
><br>
> +namespace cflaa {<br>
> +struct AliasSummary;<br>
> +}<br>
> +<br>
> class CFLAndersAAResult : public AAResultBase<CFLAndersAAResult> {<br>
> friend AAResultBase<CFLAndersAAResult>;<br>
><br>
> public:<br>
> explicit CFLAndersAAResult();<br>
><br>
> + /// \brief Get the alias summary for the given function<br>
> + /// Return nullptr if the summary is not found or not available<br>
> + const cflaa::AliasSummary *getAliasSummary(Function &Fn) {<br>
> + // Dummy implementation<br>
> + return nullptr;<br>
> + }<br>
> +<br>
> AliasResult alias(const MemoryLocation &LocA, const MemoryLocation &LocB) {<br>
> // Dummy implementation<br>
> return AAResultBase::alias(LocA, LocB);<br>
><br>
> Modified: llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h?rev=274958&r1=274957&r2=274958&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h?rev=274958&r1=274957&r2=274958&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h (original)<br>
> +++ llvm/trunk/include/llvm/Analysis/CFLSteensAliasAnalysis.h Fri Jul 8 21:54:42 2016<br>
> @@ -29,6 +29,10 @@ namespace llvm {<br>
><br>
> class TargetLibraryInfo;<br>
><br>
> +namespace cflaa {<br>
> +struct AliasSummary;<br>
> +}<br>
> +<br>
> class CFLSteensAAResult : public AAResultBase<CFLSteensAAResult> {<br>
> friend AAResultBase<CFLSteensAAResult>;<br>
> class FunctionInfo;<br>
> @@ -52,6 +56,10 @@ public:<br>
> /// Returns the appropriate entry from the cache.<br>
> const Optional<FunctionInfo> &ensureCached(Function *Fn);<br>
><br>
> + /// \brief Get the alias summary for the given function<br>
> + /// Return nullptr if the summary is not found or not available<br>
> + const cflaa::AliasSummary *getAliasSummary(Function &Fn);<br>
> +<br>
> AliasResult query(const MemoryLocation &LocA, const MemoryLocation &LocB);<br>
><br>
> AliasResult alias(const MemoryLocation &LocA, const MemoryLocation &LocB) {<br>
><br>
> Modified: llvm/trunk/lib/Analysis/AliasAnalysisSummary.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/AliasAnalysisSummary.h?rev=274958&r1=274957&r2=274958&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/AliasAnalysisSummary.h?rev=274958&r1=274957&r2=274958&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Analysis/AliasAnalysisSummary.h (original)<br>
> +++ llvm/trunk/lib/Analysis/AliasAnalysisSummary.h Fri Jul 8 21:54:42 2016<br>
> @@ -36,6 +36,7 @@<br>
> #define LLVM_ANALYSIS_ALIASANALYSISSUMMARY_H<br>
><br>
> #include "llvm/ADT/Optional.h"<br>
> +#include "llvm/ADT/SmallVector.h"<br>
> #include "llvm/IR/CallSite.h"<br>
> #include <bitset><br>
><br>
> @@ -96,6 +97,9 @@ AliasAttrs getExternallyVisibleAttrs(Ali<br>
> // Function summary related stuffs<br>
> //===----------------------------------------------------------------------===//<br>
><br>
> +/// The maximum number of arguments we can put into a summary.<br>
> +static unsigned MaxSupportedArgsInSummary = 50;<br>
> +<br>
<br>
<br>
</div></div>GCC6 complains :(<br>
[15/52] Building CXX object<br>
lib/Analysis/CMakeFiles/LLVMAnalysis.dir/AliasAnalysisSummary.cpp.o<br>
In file included from ../lib/Analysis/AliasAnalysisSummary.cpp:1:0:<br>
../lib/Analysis/AliasAnalysisSummary.h:101:17: warning:<br>
‘llvm::cflaa::MaxSupportedArgsInSummary’ defined but not used<br>
[-Wunused-variable]<br>
static unsigned MaxSupportedArgsInSummary = 50;<br>
^~~~~~~~~~~~~~~~~~~~~~~~~<br>
<br>
It could be a false positive, but, just in case, can you please take a look?<br>
<br>
Thanks!<br>
<span><font color="#888888"><br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</font></span></blockquote></div><br></div></div>