<div dir="ltr">Hi,<div><br></div><div>Am I being stupid? Why are you taking the absolute value of a square root - this should always be positive?</div><div><br></div><div>James</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, 7 Jul 2016 at 19:55 David Majnemer via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">majnemer added inline comments.<br>
<br>
================<br>
Comment at: lib/Transforms/Utils/SimplifyLibCalls.cpp:1071<br>
@@ +1070,3 @@<br>
+        emitUnaryFloatFnCall(Sqrt, "fabs", B, Callee->getAttributes());<br>
+    if (isFiniteMathMode(F))<br>
+      return FAbs;<br>
----------------<br>
Hmm.  Why not check to see if the call-site is annotated with `ninf nnan`?<br>
<br>
<br>
<a href="http://reviews.llvm.org/D22104" rel="noreferrer" target="_blank">http://reviews.llvm.org/D22104</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>