<div dir="ltr">Yes - that looks nicer:<br><a href="http://reviews.llvm.org/rL274670" rel="noreferrer" target="_blank">http://reviews.llvm.org/rL274670</a><br><br>Thanks!</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 6, 2016 at 12:09 PM, Eli Friedman <span dir="ltr"><<a href="mailto:eli.friedman@gmail.com" target="_blank">eli.friedman@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="h5">On Sun, Jul 3, 2016 at 7:34 AM, Sanjay Patel via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br></div></div><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: spatel<br>
Date: Sun Jul  3 09:34:39 2016<br>
New Revision: 274465<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=274465&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=274465&view=rev</a><br>
Log:<br>
[InstCombine] enable vector select of bools -> logic folds<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp<br>
    llvm/trunk/test/Transforms/InstCombine/select.ll<br>
<br>
Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp?rev=274465&r1=274464&r2=274465&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp?rev=274465&r1=274464&r2=274465&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp Sun Jul  3 09:34:39 2016<br>
@@ -918,9 +918,11 @@ Instruction *InstCombiner::visitSelectIn<br>
           SimplifySelectInst(CondVal, TrueVal, FalseVal, DL, TLI, DT, AC))<br>
     return replaceInstUsesWith(SI, V);<br>
<br>
-  if (SI.getType()->isIntegerTy(1)) {<br>
-    if (ConstantInt *C = dyn_cast<ConstantInt>(TrueVal)) {<br>
-      if (C->getZExtValue()) {<br>
+  if (SI.getType()->getScalarType()->isIntegerTy(1) &&<br>
+      TrueVal->getType() == CondVal->getType()) {<br>
+    const APInt *TrueC;<br>
+    if (match(TrueVal, m_APInt(TrueC))) {<br>
+      if (TrueC->isAllOnesValue()) {<br></blockquote><div><br></div></div></div><div>m_One()?<br></div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
         // Change: A = select B, true, C --> A = or B, C<br>
         return BinaryOperator::CreateOr(CondVal, FalseVal);<br>
       }<br>
@@ -928,8 +930,9 @@ Instruction *InstCombiner::visitSelectIn<br>
       Value *NotCond = Builder->CreateNot(CondVal, "not." + CondVal->getName());<br>
       return BinaryOperator::CreateAnd(NotCond, FalseVal);<br>
     }<br>
-    if (ConstantInt *C = dyn_cast<ConstantInt>(FalseVal)) {<br>
-      if (!C->getZExtValue()) {<br>
+    const APInt *FalseC;<br>
+    if (match(FalseVal, m_APInt(FalseC))) {<br></blockquote><div><br></div></span><div>m_Zero()?<span class="HOEnZb"><font color="#888888"><br><br></font></span></div><span class="HOEnZb"><font color="#888888"><div>-Eli<br></div></font></span></div></div></div>
</blockquote></div><br></div>