<div dir="ltr">I believe you mis-interpreted the problem: the MB is the total size, and that line matches. The problem looks like (though FileCheck output is confusing) there are not enough samples to have any in array #1, which is a tougher problem to solve.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 5, 2016 at 8:20 PM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I took a wild stab in the dark at fixing this in r274587. Hopefully it is not just papering over an existing bug but its either that or reverting the changes that added the test in the first place.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 5, 2016 at 3:12 PM, Justin Bogner via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>Derek Bruening via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> writes:<br>
> Please provide a pointer to which bots. It is not easy to find which ones<br>
> are being referred to at <a href="http://lab.llvm.org:8011/waterfall" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/waterfall</a> in order to see<br>
> the precise test output.<br>
<br>
</span>The output is as David wrote, but here's a run that failed like this<br>
today:<br>
<br>
<a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/39465" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/39465</a><br>
<br>
This seems to be happening fairly frequently right now.<br>
<div><div><br>
> On Fri, Jul 1, 2016 at 1:51 PM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>><br>
> wrote:<br>
><br>
>> Any update here? the build bots are flaking because of this test.<br>
>><br>
>> On Thu, Jun 23, 2016 at 11:22 PM David Majnemer via llvm-commits <<br>
>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>>> Still seems flaky:<br>
>>><br>
>>> /home/llvmbb/llvm-build-dir/llvm-clang-lld-x86_64-debian-fast/llvm.src/projects/compiler-rt/test/esan/TestCases/workingset-samples.cpp:25:17:<br>
>>> error: expected string not found in input<br>
>>> // CHECK-NEXT: =={{[0-9]+}}==# 0: {{[ 0-9]+}} {{KB|Bytes}} ({{[ 0-9]+}}<br>
>>> cache lines)<br>
>>> ^<br>
>>> <stdin>:4:1: note: scanning from here<br>
>>> ==21268== Samples array #1 at period 80 ms<br>
>>> ^<br>
>>> <stdin>:11:36: note: possible intended match here<br>
>>> ==21268== EfficiencySanitizer: the total working set size: 32 MB (524289<br>
>>> cache lines)<br>
>>><br>
>>> Looks like the regex pattern should be expanded further?<br>
>>><br>
>>> On Wed, Jun 8, 2016 at 10:35 AM, Derek Bruening via llvm-commits <<br>
>>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>>><br>
>>>> Author: bruening<br>
>>>> Date: Wed Jun 8 12:35:52 2016<br>
>>>> New Revision: 272175<br>
>>>><br>
>>>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=272175&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=272175&view=rev</a><br>
>>>> Log:<br>
>>>> [esan|wset] Reduce flakiness in samples test<br>
>>>><br>
>>>> Generalizes the workingset-samples test to pass when a sample has a<br>
>>>> size of 0, which can happen on a loaded machine.<br>
>>>><br>
>>>> Modified:<br>
>>>> compiler-rt/trunk/test/esan/TestCases/workingset-samples.cpp<br>
>>>><br>
>>>> Modified: compiler-rt/trunk/test/esan/TestCases/workingset-samples.cpp<br>
>>>> URL:<br>
>>>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/esan/TestCases/workingset-samples.cpp?rev=272175&r1=272174&r2=272175&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/esan/TestCases/workingset-samples.cpp?rev=272175&r1=272174&r2=272175&view=diff</a><br>
>>>><br>
>>>> ==============================================================================<br>
>>>> --- compiler-rt/trunk/test/esan/TestCases/workingset-samples.cpp<br>
>>>> (original)<br>
>>>> +++ compiler-rt/trunk/test/esan/TestCases/workingset-samples.cpp Wed<br>
>>>> Jun 8 12:35:52 2016<br>
>>>> @@ -22,12 +22,12 @@ int main(int argc, char **argv) {<br>
>>>> // We only check for a few samples here to reduce the chance of<br>
>>>> flakiness.<br>
>>>> // CHECK: =={{[0-9]+}}== Total number of samples: {{[0-9]+}}<br>
>>>> // CHECK-NEXT: =={{[0-9]+}}== Samples array #0 at period 20 ms<br>
>>>> - // CHECK-NEXT: =={{[0-9]+}}==# 0: {{[ 0-9]+}} KB ({{[ 0-9]+}} cache<br>
>>>> lines)<br>
>>>> - // CHECK-NEXT: =={{[0-9]+}}==# 1: {{[ 0-9]+}} KB ({{[ 0-9]+}} cache<br>
>>>> lines)<br>
>>>> - // CHECK-NEXT: =={{[0-9]+}}==# 2: {{[ 0-9]+}} KB ({{[ 0-9]+}} cache<br>
>>>> lines)<br>
>>>> - // CHECK-NEXT: =={{[0-9]+}}==# 3: {{[ 0-9]+}} KB ({{[ 0-9]+}} cache<br>
>>>> lines)<br>
>>>> + // CHECK-NEXT: =={{[0-9]+}}==# 0: {{[ 0-9]+}} {{KB|Bytes}} ({{[<br>
>>>> 0-9]+}} cache lines)<br>
>>>> + // CHECK-NEXT: =={{[0-9]+}}==# 1: {{[ 0-9]+}} {{KB|Bytes}} ({{[<br>
>>>> 0-9]+}} cache lines)<br>
>>>> + // CHECK-NEXT: =={{[0-9]+}}==# 2: {{[ 0-9]+}} {{KB|Bytes}} ({{[<br>
>>>> 0-9]+}} cache lines)<br>
>>>> + // CHECK-NEXT: =={{[0-9]+}}==# 3: {{[ 0-9]+}} {{KB|Bytes}} ({{[<br>
>>>> 0-9]+}} cache lines)<br>
>>>> // CHECK: =={{[0-9]+}}== Samples array #1 at period 80 ms<br>
>>>> - // CHECK-NEXT: =={{[0-9]+}}==# 0: {{[ 0-9]+}} KB ({{[ 0-9]+}} cache<br>
>>>> lines)<br>
>>>> + // CHECK-NEXT: =={{[0-9]+}}==# 0: {{[ 0-9]+}} {{KB|Bytes}} ({{[<br>
>>>> 0-9]+}} cache lines)<br>
>>>> // CHECK: =={{[0-9]+}}== Samples array #2 at period 320 ms<br>
>>>> // CHECK: =={{[0-9]+}}== Samples array #3 at period 1280 ms<br>
>>>> // CHECK: =={{[0-9]+}}== Samples array #4 at period 5120 ms<br>
>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> llvm-commits mailing list<br>
>>>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>>>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
>>>><br>
>>><br>
>>> _______________________________________________<br>
>>> llvm-commits mailing list<br>
>>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
>>><br>
>><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>