<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 28, 2016 at 6:28 PM Tim Shen <<a href="mailto:timshen@google.com">timshen@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">timshen added a comment.<br>
<br>
The functional change is here:<br>
<a href="https://gist.github.com/timshen91/51b209c8d1be22ef96a1a9fd4131595d#file-fcmp-diff-diff" rel="noreferrer" target="_blank">https://gist.github.com/timshen91/51b209c8d1be22ef96a1a9fd4131595d#file-fcmp-diff-diff</a><br>
<br>
I verified the differences, and considered them valid. PTAL. Specifically, there are bug fixes from line 2586 to line 2643; others are just optimizations.<br>
<br>
<br>
<a href="http://reviews.llvm.org/D21775" rel="noreferrer" target="_blank">http://reviews.llvm.org/D21775</a></blockquote><div><br></div><div>Be nice to be able to split out the NFC testcase changes from the ones that matter if you can.</div><div><br></div><div>-ericĀ </div></div></div>