<div dir="ltr">I've done it here:<div><br></div><div><div>Committing to <a href="https://llvm.org/svn/llvm-project/llvm/trunk">https://llvm.org/svn/llvm-project/llvm/trunk</a> ...</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>D<span class="Apple-tab-span" style="white-space:pre"> </span>test/Transforms/InstCombine/pr25342.ll</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>D<span class="Apple-tab-span" style="white-space:pre"> </span>test/Transforms/InstCombine/pr27703.ll</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>M<span class="Apple-tab-span" style="white-space:pre"> </span>lib/Transforms/InstCombine/InstCombineCasts.cpp</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>M<span class="Apple-tab-span" style="white-space:pre"> </span>lib/Transforms/InstCombine/InstCombineInternal.h</div><div>Committed r274094</div></div><div><br></div><div>I'll follow up to the latter of the original commits.</div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 28, 2016 at 11:46 AM Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi All,<div><br></div><div>Please go ahead and revert these. I've just noticed this thread, but Carrot is on vacation for a few weeks and so likely isn't reading this.</div><div><br></div><div>Do follow up on the original commits and let him know what you've done.</div><div><br></div><div>Thanks!</div></div><div dir="ltr"><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 28, 2016 at 10:08 AM Daniel Berlin <<a href="mailto:dberlin@dberlin.org" target="_blank">dberlin@dberlin.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">In situations like this, where it is causing demonstrable issues and appears broken, two "votes" are enough to revert the change.<div><br></div><div>You should ask the author to revert the change, explicitly, in a separate thread (a lot of people filter review mail).<div>If they don't do so expediently, you should revert it for them, and ask them to take a look at fixing when they get a chance.</div><div><br></div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 28, 2016 at 3:27 AM, Evgeny Stupachenko <span dir="ltr"><<a href="mailto:evstupac@gmail.com" target="_blank">evstupac@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">evstupac added a comment.<br>
<br>
Sorry if I am missing something.<br>
But is 2 votes here enough to revert the revisions?<br>
Should author do this? Or I can do this as well?<br>
There are still no vote from author and reviewer.<br>
<div class="m_7191391229826592551m_-4147967111803684332HOEnZb"><div class="m_7191391229826592551m_-4147967111803684332h5"><br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D20847" rel="noreferrer" target="_blank">http://reviews.llvm.org/D20847</a><br>
<br>
<br>
<br>
</div></div></blockquote></div><br></div>
</blockquote></div></blockquote></div>