<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi,<br>
That should be addressed in r274008. Could you confirm that it
is okay?<br>
Many thanks,<br>
Vassil<br>
On 09/06/16 01:21, Richard Smith wrote:<br>
</div>
<blockquote
cite="mid:CAOfiQqnJcm+AY7pdFZPNH4SsBrN_vehpr00cBL-ouJ7AbGc=_w@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Thu, May 26, 2016 at 2:21 AM,
Vassil Vassilev <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:v.g.vassilev@gmail.com" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:v.g.vassilev@gmail.com">v.g.vassilev@gmail.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class="">
<div>On 26/05/16 00:42, Richard Smith wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Seems really weird to have a modules
flag to getClangBuildFactory that doesn't actually
turn on -DLLVM_ENABLE_MODULES. What's the reason
for removing this:
<div><br>
</div>
<div>
<div>- if modules:</div>
<div>- extra_args =
['-DLLVM_ENABLE_MODULES=1']</div>
</div>
<div><br>
</div>
<div>?</div>
</div>
</blockquote>
</span> I wanted to move all extra_args into
stage2_extra_configure_args. I can revert this part.
However it seems that the only use of the modules flag
is go add a "prebuild" step
"compile.llvm.stage2.intrinsics_gen". Do we need this,
on my machine it works just fine without?</div>
</blockquote>
<div><br>
</div>
<div>Yes, we need this. A -j build will otherwise
*sometimes* fail, depending on whether the steps that
consume the IR module happen to start before or after
intrinsics.gen is generated by tablegen.</div>
<div><br>
</div>
<div>We could fix this by splitting the LLVM IR module up
into the pieces that use intrinsics.gen and the pieces
that don't; I don't think we're actually missing build
dependencies here, but the relevant modules are too
coarse.</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>
<div class="h5">
<blockquote type="cite">
<div class="gmail_extra">
<div class="gmail_quote">On Wed, May 25, 2016 at
10:17 AM, Vassil Vassilev <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:v.g.vassilev@gmail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:v.g.vassilev@gmail.com">v.g.vassilev@gmail.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>Done in r270725. Thanks for
reviewing!<span><font color="#888888"><br>
-- Vassil</font></span>
<div>
<div><br>
On 25/05/16 19:00, Galina Kistanova
wrote:<br>
</div>
</div>
</div>
<div>
<div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>Looks ok, please commit
it.<br>
<br>
</div>
Thanks<br>
<br>
</div>
Galina<br>
<br>
<br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed,
May 25, 2016 at 5:19 AM,
Vassil Vassilev <span
dir="ltr"><<a
moz-do-not-send="true"
href="mailto:v.g.vassilev@gmail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:v.g.vassilev@gmail.com">v.g.vassilev@gmail.com</a></a>></span>
wrote:<br>
<blockquote
class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex">Hi
Galina,<br>
I am attaching a patch
that I believe fixes the
issue. Could you review it
please (I don't know how to
test it).<br>
Many thanks,<br>
Vassil
<div>
<div><br>
On 25/05/16 11:36,
Vassil Vassilev wrote:<br>
<blockquote
class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px
#ccc
solid;padding-left:1ex">
This broke our modules
slaves. I am working
on a fix. Sorry for
the inconvenience!<br>
-- Vassil<br>
On 24/05/16 11:23,
Vassil Vassilev via
llvm-commits wrote:<br>
<blockquote
class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px
#ccc
solid;padding-left:1ex">
Author: vvassilev<br>
Date: Tue May 24
04:22:58 2016<br>
New Revision: 270539<br>
<br>
URL: <a
moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=270539&view=rev"
rel="noreferrer"
target="_blank"><a class="moz-txt-link-freetext" href="http://llvm.org/viewvc/llvm-project?rev=270539&view=rev">http://llvm.org/viewvc/llvm-project?rev=270539&view=rev</a></a><br>
Log:<br>
Enable modules
selfhosting builds
with libstdc++, too.<br>
<br>
If a modulemap is
not present (in the
case of libstdc++),
we will end up with<br>
duplicate entities
in the modules. This
will help us stress
test the module<br>
merging and discover
potential bugs.<br>
<br>
Modified:<br>
zorg/trunk/zorg/buildbot/builders/ClangBuilder.py<br>
<br>
Modified:
zorg/trunk/zorg/buildbot/builders/ClangBuilder.py<br>
URL: <a
moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/ClangBuilder.py?rev=270539&r1=270538&r2=270539&view=diff"
rel="noreferrer"
target="_blank"><a class="moz-txt-link-freetext" href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/ClangBuilder.py?rev=270539&r1=270538&r2=270539&view=diff">http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/ClangBuilder.py?rev=270539&r1=270538&r2=270539&view=diff</a></a><br>
==============================================================================
<br>
---
zorg/trunk/zorg/buildbot/builders/ClangBuilder.py
(original)<br>
+++
zorg/trunk/zorg/buildbot/builders/ClangBuilder.py
Tue May 24 04:22:58
2016<br>
@@ -281,8 +281,6 @@
def
getClangBuildFactory(<br>
cxx_flags = ''<br>
extra_args =
[]<br>
if modules:<br>
- # Modules
requires libc++ for
now (we don't have a
module map for
libstdc++ yet).<br>
- cxx_flags
+= '-stdlib=libc++'<br>
extra_args
=
['-DLLVM_ENABLE_MODULES=1']<br>
f.addStep(ShellCommand(name='cmake',<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing
list<br>
<a
moz-do-not-send="true"
href="mailto:llvm-commits@lists.llvm.org" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a></a><br>
<a
moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits"
rel="noreferrer"
target="_blank"><a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></a><br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<p><br>
</p>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<p><br>
</p>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>