<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><div><blockquote type="cite" class=""><div class="">On Jun 24, 2016, at 5:49 PM, Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org" class="">compnerd@compnerd.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">On Tue, Jun 21, 2016 at 2:37 PM, Chris Bieneman via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">beanz updated this revision to Diff 61451.<br class="">
beanz added a comment.<br class="">
<br class="">
I kinda went a bit off into the woods after the llvm-dev thread, and I think I came back with something either interesting or insane... you decide.<br class="">
<br class="">
This patch changed a few things about how I'm handling the runtimes subdirectory. First, it handles the compiler-rt builtin library dependency by building the builtins first as their own external project call. Second, it glumps all the other runtime libraries (including compiler-rt's sanitizers) into a single external project by using the runtimes/CMakeLists.txt file as the top-level CMake.<br class=""></blockquote><div class=""><br class=""></div><div class="">Is the intent that the sanitizer runtimes and the C++ runtime would be a single project?</div></div></div></div></div></blockquote><div><br class=""></div><div>Not really one project. What it does is disconnect the configure-time and build-time dependencies. The builtins are configured and built first and separately. Then the remaining runtimes can be configured in a single group, and built respecting the dependencies across project boundaries.</div><div><br class=""></div><div>Does that make sense?</div><div><br class=""></div><div>-Chris</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> If so, that seems a bit imprecise. However, this is engineering, and if it does result in a more maintainable system, it may be worth it. The builtins definitely need to be pulled out into a separate project. It feels like the right layering here would be something like:</div><div class=""><br class=""></div><div class="">builtins</div><div class="">unwind</div><div class="">sanitizers</div><div class="">libc++abi / libc++</div><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This is interesting for a few reasons. The biggest is a potential for reduced CMake-overhead when building runtime libraries. Additionally it will allow cross-project dependencies to be more easily modeled in CMake because the runtime libraries will be able to be aware of the targets coming from other runtime projects.<br class="">
<br class="">
Thoughts?<br class="">
<div class="HOEnZb"><div class="h5"><br class="">
<br class="">
<a href="http://reviews.llvm.org/D20992" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D20992</a><br class="">
<br class="">
Files:<br class="">
CMakeLists.txt<br class="">
cmake/modules/LLVMExternalProjectUtils.cmake<br class="">
runtimes/CMakeLists.txt<br class="">
<br class="">
</div></div><br class="">_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
<br class=""></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br class="">compnerd (at) compnerd (dot) org</div>
</div></div>
</div></blockquote></div><br class=""></div></body></html>