<div dir="ltr">I disagree. I don't think this makes sense. Either the linker you're using supports this feature, or it doesn't. Having it enabled for llc if your linker doesn't support it is not fun.<br><div><div></div></div><div><br></div><div>Further note that this also affects basically all other code using llvm libraries -- other than Clang, which explicitly sets it back to false by default, unless you set the <span class="gmail-s1">ENABLE_X86</span><span class="gmail-s2">_RELAX_RELOCATIONS </span>cmake flag to true.</div>
<div><br></div><div><div>If you want to enable the relax mode across all llvm tools in some circumstances, I think it should be via moving the cmake flag from clang down into llvm.</div><div><div><div><div><br></div><div>I'm going to revert this commit, since I both think it intrinsically doesn't make sense to do this, and because it's breaking some of our tools.<br></div><div><br></div></div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 17, 2016 at 1:43 PM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Fri Jun 17 12:43:41 2016<br>
New Revision: 273019<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=273019&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=273019&view=rev</a><br>
Log:<br>
Change RelaxELFRelocations for llc.<br>
<br>
As a developer tool it makes sense for it to use the new relocations.<br>
<br>
Added:<br>
llvm/trunk/test/CodeGen/X86/relax-reloc.ll<br>
Modified:<br>
llvm/trunk/include/llvm/Target/TargetOptions.h<br>
<br>
Modified: llvm/trunk/include/llvm/Target/TargetOptions.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetOptions.h?rev=273019&r1=273018&r2=273019&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetOptions.h?rev=273019&r1=273018&r2=273019&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Target/TargetOptions.h (original)<br>
+++ llvm/trunk/include/llvm/Target/TargetOptions.h Fri Jun 17 12:43:41 2016<br>
@@ -98,7 +98,7 @@ namespace llvm {<br>
GuaranteedTailCallOpt(false), StackAlignmentOverride(0),<br>
StackSymbolOrdering(true), EnableFastISel(false), UseInitArray(false),<br>
DisableIntegratedAS(false), CompressDebugSections(false),<br>
- RelaxELFRelocations(false), FunctionSections(false),<br>
+ RelaxELFRelocations(true), FunctionSections(false),<br>
DataSections(false), UniqueSectionNames(true), TrapUnreachable(false),<br>
EmulatedTLS(false), FloatABIType(FloatABI::Default),<br>
AllowFPOpFusion(FPOpFusion::Standard), Reciprocals(TargetRecip()),<br>
<br>
Added: llvm/trunk/test/CodeGen/X86/relax-reloc.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/relax-reloc.ll?rev=273019&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/relax-reloc.ll?rev=273019&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/X86/relax-reloc.ll (added)<br>
+++ llvm/trunk/test/CodeGen/X86/relax-reloc.ll Fri Jun 17 12:43:41 2016<br>
@@ -0,0 +1,15 @@<br>
+; RUN: llc %s -o %t.o -filetype=obj -relocation-model=pic<br>
+; RUN: llvm-readobj -r %t.o | FileCheck %s<br>
+; CHECK: Section ({{.}}) .rela.text {<br>
+; CHECK-NEXT: 0x3 R_X86_64_REX_GOTPCRELX a 0xFFFFFFFFFFFFFFFC<br>
+; CHECK-NEXT: }<br>
+<br>
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"<br>
+target triple = "x86_64-unknown-linux-gnu"<br>
+<br>
+@a = external global i32<br>
+<br>
+define i32 @f() {<br>
+ %t = load i32, i32* @a<br>
+ ret i32 %t<br>
+}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>