<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Tue, Jun 21, 2016 at 2:57 AM Reid Kleckner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Mon Jun 20 18:50:21 2016<br>
New Revision: 273223<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=273223&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=273223&view=rev</a><br>
Log:<br>
Use the same tag type across all PointerLikeTypeTraits specializations<br>
<br>
Works around a bug (PR28216) in Clang's MS mangling of templates with<br>
partial specializations.<br>
<br>
This mismatch was introduced in about six months ago in r256656.<br></blockquote><div><br></div><div>Thanks.</div><div><br></div><div>Also, UGH.</div><div><br></div><div>Don't we have a warning to catch this? Can we turn it on if we're going to have to care?</div><div><br></div><div>(I'd much rather not care, but I understand that MS's ABI has made that impossible?)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/include/llvm/Support/PointerLikeTypeTraits.h<br>
<br>
Modified: llvm/trunk/include/llvm/Support/PointerLikeTypeTraits.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/PointerLikeTypeTraits.h?rev=273223&r1=273222&r2=273223&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/PointerLikeTypeTraits.h?rev=273223&r1=273222&r2=273223&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Support/PointerLikeTypeTraits.h (original)<br>
+++ llvm/trunk/include/llvm/Support/PointerLikeTypeTraits.h Mon Jun 20 18:50:21 2016<br>
@@ -37,7 +37,8 @@ template <> struct ConstantLog2<1> : std<br>
 }<br>
<br>
 // Provide PointerLikeTypeTraits for non-cvr pointers.<br>
-template <typename T> struct PointerLikeTypeTraits<T *> {<br>
+template <typename T> class PointerLikeTypeTraits<T *> {<br>
+public:<br>
   static inline void *getAsVoidPointer(T *P) { return P; }<br>
   static inline T *getFromVoidPointer(void *P) { return static_cast<T *>(P); }<br>
<br>
@@ -46,7 +47,8 @@ template <typename T> struct PointerLike<br>
   };<br>
 };<br>
<br>
-template <> struct PointerLikeTypeTraits<void *> {<br>
+template <> class PointerLikeTypeTraits<void *> {<br>
+public:<br>
   static inline void *getAsVoidPointer(void *P) { return P; }<br>
   static inline void *getFromVoidPointer(void *P) { return P; }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>