<div dir="ltr">Thanks for the review. Done.<div><br></div><div>David</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 15, 2016 at 3:10 PM, Davide Italiano <span dir="ltr"><<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Jun 15, 2016 at 2:51 PM, Xinliang David Li via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: davidxl<br>
> Date: Wed Jun 15 16:51:30 2016<br>
> New Revision: 272847<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=272847&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=272847&view=rev</a><br>
> Log:<br>
> [PM] Port Add discriminator pass to new PM<br>
><br>
<br>
Thanks for taking care of the porting. Some post-commit comments below.<br>
<br>
> Added:<br>
> llvm/trunk/include/llvm/Transforms/Utils/AddDiscriminators.h<br>
> Modified:<br>
> llvm/trunk/include/llvm/InitializePasses.h<br>
> llvm/trunk/lib/Passes/PassBuilder.cpp<br>
> llvm/trunk/lib/Passes/PassRegistry.def<br>
> llvm/trunk/lib/Transforms/Utils/AddDiscriminators.cpp<br>
> llvm/trunk/lib/Transforms/Utils/Utils.cpp<br>
> llvm/trunk/test/Transforms/AddDiscriminators/basic.ll<br>
> llvm/trunk/test/Transforms/AddDiscriminators/call-nested.ll<br>
> llvm/trunk/test/Transforms/AddDiscriminators/call.ll<br>
> llvm/trunk/test/Transforms/AddDiscriminators/dbg-declare-discriminator.ll<br>
> llvm/trunk/test/Transforms/AddDiscriminators/diamond.ll<br>
> llvm/trunk/test/Transforms/AddDiscriminators/first-only.ll<br>
> llvm/trunk/test/Transforms/AddDiscriminators/multiple.ll<br>
> llvm/trunk/test/Transforms/AddDiscriminators/no-discriminators.ll<br>
> llvm/trunk/test/Transforms/AddDiscriminators/oneline.ll<br>
><br>
> Modified: llvm/trunk/include/llvm/InitializePasses.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/InitializePasses.h?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/InitializePasses.h?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/InitializePasses.h (original)<br>
> +++ llvm/trunk/include/llvm/InitializePasses.h Wed Jun 15 16:51:30 2016<br>
> @@ -58,7 +58,7 @@ void initializeTarget(PassRegistry&);<br>
> void initializeAAEvalLegacyPassPass(PassRegistry&);<br>
> void initializeAAResultsWrapperPassPass(PassRegistry &);<br>
> void initializeADCELegacyPassPass(PassRegistry&);<br>
> -void initializeAddDiscriminatorsPass(PassRegistry&);<br>
> +void initializeAddDiscriminatorsLegacyPassPass(PassRegistry&);<br>
> void initializeAddressSanitizerModulePass(PassRegistry&);<br>
> void initializeAddressSanitizerPass(PassRegistry&);<br>
> void initializeAliasSetPrinterPass(PassRegistry&);<br>
><br>
> Added: llvm/trunk/include/llvm/Transforms/Utils/AddDiscriminators.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Transforms/Utils/AddDiscriminators.h?rev=272847&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Transforms/Utils/AddDiscriminators.h?rev=272847&view=auto</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/Transforms/Utils/AddDiscriminators.h (added)<br>
> +++ llvm/trunk/include/llvm/Transforms/Utils/AddDiscriminators.h Wed Jun 15 16:51:30 2016<br>
> @@ -0,0 +1,30 @@<br>
> +//===- AddDiscriminators.h -------------------------------------*- C++ -*-===//<br>
> +//<br>
> +// The LLVM Compiler Infrastructure<br>
> +//<br>
> +// This file is distributed under the University of Illinois Open Source<br>
> +// License. See LICENSE.TXT for details.<br>
> +//<br>
> +//===----------------------------------------------------------------------===//<br>
> +//<br>
> +// This pass adds DWARF discriminators to the IR. Path discriminators are used<br>
> +// to decide what CFG path was taken inside sub-graphs whose instructions share<br>
> +// the same line and column number information.<br>
> +//<br>
> +//===----------------------------------------------------------------------===//<br>
> +<br>
> +#ifndef LLVM_TRANSFORMS_UTILS_ADDDISCRIMINATORS_H<br>
> +#define LLVM_TRANSFORMS_UTILS_ADDDISCRIMINATORS_H<br>
> +<br>
> +#include "llvm/IR/PassManager.h"<br>
> +<br>
> +namespace llvm {<br>
> +<br>
> +/// Converts loops into loop-closed SSA form.<br>
<br>
I think this comment is wrong?<br>
<br>
> +class AddDiscriminatorsPass : public PassInfoMixin<AddDiscriminatorsPass> {<br>
> +public:<br>
> + PreservedAnalyses run(Function &F, AnalysisManager<Function> &AM);<br>
> +};<br>
> +} // end namespace llvm<br>
> +<br>
> +#endif // LLVM_TRANSFORMS_UTILS_LCSSA_H<br>
<br>
Ditto.<br>
<br>
><br>
> Modified: llvm/trunk/lib/Passes/PassBuilder.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Passes/PassBuilder.cpp?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Passes/PassBuilder.cpp?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Passes/PassBuilder.cpp (original)<br>
> +++ llvm/trunk/lib/Passes/PassBuilder.cpp Wed Jun 15 16:51:30 2016<br>
> @@ -90,6 +90,7 @@<br>
> #include "llvm/Transforms/Scalar/SROA.h"<br>
> #include "llvm/Transforms/Scalar/SimplifyCFG.h"<br>
> #include "llvm/Transforms/Scalar/Sink.h"<br>
> +#include "llvm/Transforms/Utils/AddDiscriminators.h"<br>
> #include "llvm/Transforms/Scalar/SLPVectorizer.h"<br>
> #include "llvm/Transforms/Utils/LCSSA.h"<br>
> #include "llvm/Transforms/Utils/Mem2Reg.h"<br>
><br>
> Modified: llvm/trunk/lib/Passes/PassRegistry.def<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Passes/PassRegistry.def?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Passes/PassRegistry.def?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Passes/PassRegistry.def (original)<br>
> +++ llvm/trunk/lib/Passes/PassRegistry.def Wed Jun 15 16:51:30 2016<br>
> @@ -119,6 +119,7 @@ FUNCTION_ALIAS_ANALYSIS("type-based-aa",<br>
> #endif<br>
> FUNCTION_PASS("aa-eval", AAEvaluator())<br>
> FUNCTION_PASS("adce", ADCEPass())<br>
> +FUNCTION_PASS("add-discriminators", AddDiscriminatorsPass())<br>
> FUNCTION_PASS("alignment-from-assumptions", AlignmentFromAssumptionsPass())<br>
> FUNCTION_PASS("bdce", BDCEPass())<br>
> FUNCTION_PASS("dce", DCEPass())<br>
><br>
> Modified: llvm/trunk/lib/Transforms/Utils/AddDiscriminators.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/AddDiscriminators.cpp?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/AddDiscriminators.cpp?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Transforms/Utils/AddDiscriminators.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/Utils/AddDiscriminators.cpp Wed Jun 15 16:51:30 2016<br>
> @@ -52,6 +52,7 @@<br>
> // <a href="http://wiki.dwarfstd.org/index.php?title=Path_Discriminators" rel="noreferrer" target="_blank">http://wiki.dwarfstd.org/index.php?title=Path_Discriminators</a><br>
> //===----------------------------------------------------------------------===//<br>
><br>
> +#include "llvm/Transforms/Utils/AddDiscriminators.h"<br>
> #include "llvm/ADT/DenseMap.h"<br>
> #include "llvm/ADT/DenseSet.h"<br>
> #include "llvm/IR/BasicBlock.h"<br>
> @@ -73,20 +74,22 @@ using namespace llvm;<br>
> #define DEBUG_TYPE "add-discriminators"<br>
><br>
> namespace {<br>
> -struct AddDiscriminators : public FunctionPass {<br>
> +// The legacy pass of AddDiscriminators.<br>
> +struct AddDiscriminatorsLegacyPass : public FunctionPass {<br>
> static char ID; // Pass identification, replacement for typeid<br>
> - AddDiscriminators() : FunctionPass(ID) {<br>
> - initializeAddDiscriminatorsPass(*PassRegistry::getPassRegistry());<br>
> + AddDiscriminatorsLegacyPass() : FunctionPass(ID) {<br>
> + initializeAddDiscriminatorsLegacyPassPass(*PassRegistry::getPassRegistry());<br>
> }<br>
><br>
> bool runOnFunction(Function &F) override;<br>
> };<br>
> +<br>
> } // end anonymous namespace<br>
><br>
> -char AddDiscriminators::ID = 0;<br>
> -INITIALIZE_PASS_BEGIN(AddDiscriminators, "add-discriminators",<br>
> +char AddDiscriminatorsLegacyPass::ID = 0;<br>
> +INITIALIZE_PASS_BEGIN(AddDiscriminatorsLegacyPass, "add-discriminators",<br>
> "Add DWARF path discriminators", false, false)<br>
> -INITIALIZE_PASS_END(AddDiscriminators, "add-discriminators",<br>
> +INITIALIZE_PASS_END(AddDiscriminatorsLegacyPass, "add-discriminators",<br>
> "Add DWARF path discriminators", false, false)<br>
><br>
> // Command line option to disable discriminator generation even in the<br>
> @@ -96,8 +99,9 @@ static cl::opt<bool> NoDiscriminators(<br>
> "no-discriminators", cl::init(false),<br>
> cl::desc("Disable generation of discriminator information."));<br>
><br>
> +// Create the legacy AddDiscriminatorsPass.<br>
> FunctionPass *llvm::createAddDiscriminatorsPass() {<br>
> - return new AddDiscriminators();<br>
> + return new AddDiscriminatorsLegacyPass();<br>
> }<br>
><br>
> /// \brief Assign DWARF discriminators.<br>
> @@ -151,7 +155,7 @@ FunctionPass *llvm::createAddDiscriminat<br>
> /// lexical block for I2 and all the instruction in B2 that share the same<br>
> /// file and line location as I2. This new lexical block will have a<br>
> /// different discriminator number than I1.<br>
> -bool AddDiscriminators::runOnFunction(Function &F) {<br>
> +bool addDiscriminators(Function &F) {<br>
<br>
This can be probably staticized, no?<br>
<br>
> // If the function has debug information, but the user has disabled<br>
> // discriminators, do nothing.<br>
> // Simlarly, if the function has no debug info, do nothing.<br>
> @@ -240,3 +244,13 @@ bool AddDiscriminators::runOnFunction(Fu<br>
> }<br>
> return Changed;<br>
> }<br>
> +<br>
> +bool AddDiscriminatorsLegacyPass::runOnFunction(Function &F) {<br>
> + return addDiscriminators(F);<br>
> +}<br>
> +PreservedAnalyses AddDiscriminatorsPass::run(Function &F,<br>
> + AnalysisManager<Function> &AM) {<br>
> + addDiscriminators(F);<br>
> + // Only modifies debug info.<br>
> + return PreservedAnalyses::all();<br>
> +}<br>
><br>
<br>
I'd rather use the return value of addDiscriminator and preserve all<br>
the analyses iff the IR is not mutated.<br>
If you are confident that this preserves all the transformations,<br>
please commit the change separately (and do that for both the new and<br>
the old PM).<br>
<br>
> Modified: llvm/trunk/lib/Transforms/Utils/Utils.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Utils.cpp?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Utils.cpp?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Transforms/Utils/Utils.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/Utils/Utils.cpp Wed Jun 15 16:51:30 2016<br>
> @@ -21,7 +21,7 @@ using namespace llvm;<br>
> /// initializeTransformUtils - Initialize all passes in the TransformUtils<br>
> /// library.<br>
> void llvm::initializeTransformUtils(PassRegistry &Registry) {<br>
> - initializeAddDiscriminatorsPass(Registry);<br>
> + initializeAddDiscriminatorsLegacyPassPass(Registry);<br>
> initializeBreakCriticalEdgesPass(Registry);<br>
> initializeInstNamerPass(Registry);<br>
> initializeLCSSAWrapperPassPass(Registry);<br>
><br>
> Modified: llvm/trunk/test/Transforms/AddDiscriminators/basic.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/basic.ll?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/basic.ll?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/AddDiscriminators/basic.ll (original)<br>
> +++ llvm/trunk/test/Transforms/AddDiscriminators/basic.ll Wed Jun 15 16:51:30 2016<br>
> @@ -1,4 +1,5 @@<br>
> ; RUN: opt < %s -add-discriminators -S | FileCheck %s<br>
> +; RUN: opt < %s -passes=add-discriminators -S | FileCheck %s<br>
><br>
> ; Basic DWARF discriminator test. All the instructions in block<br>
> ; 'if.then' should have a different discriminator value than<br>
><br>
> Modified: llvm/trunk/test/Transforms/AddDiscriminators/call-nested.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/call-nested.ll?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/call-nested.ll?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/AddDiscriminators/call-nested.ll (original)<br>
> +++ llvm/trunk/test/Transforms/AddDiscriminators/call-nested.ll Wed Jun 15 16:51:30 2016<br>
> @@ -1,4 +1,5 @@<br>
> ; RUN: opt < %s -add-discriminators -S | FileCheck %s<br>
> +; RUN: opt < %s -passes=add-discriminators -S | FileCheck %s<br>
><br>
> ; Discriminator support for calls that are defined in one line:<br>
> ; #1 int foo(int, int);<br>
><br>
> Modified: llvm/trunk/test/Transforms/AddDiscriminators/call.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/call.ll?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/call.ll?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/AddDiscriminators/call.ll (original)<br>
> +++ llvm/trunk/test/Transforms/AddDiscriminators/call.ll Wed Jun 15 16:51:30 2016<br>
> @@ -1,4 +1,5 @@<br>
> ; RUN: opt < %s -add-discriminators -S | FileCheck %s<br>
> +; RUN: opt < %s -passes=add-discriminators -S | FileCheck %s<br>
><br>
> ; Discriminator support for calls that are defined in one line:<br>
> ; #1 void bar();<br>
><br>
> Modified: llvm/trunk/test/Transforms/AddDiscriminators/dbg-declare-discriminator.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/dbg-declare-discriminator.ll?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/dbg-declare-discriminator.ll?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/AddDiscriminators/dbg-declare-discriminator.ll (original)<br>
> +++ llvm/trunk/test/Transforms/AddDiscriminators/dbg-declare-discriminator.ll Wed Jun 15 16:51:30 2016<br>
> @@ -1,4 +1,5 @@<br>
> ; RUN: opt -S -add-discriminators < %s | FileCheck %s<br>
> +; RUN: opt -S -passes=add-discriminators < %s | FileCheck %s<br>
><br>
> declare void @llvm.dbg.declare(metadata, metadata, metadata)<br>
><br>
><br>
> Modified: llvm/trunk/test/Transforms/AddDiscriminators/diamond.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/diamond.ll?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/diamond.ll?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/AddDiscriminators/diamond.ll (original)<br>
> +++ llvm/trunk/test/Transforms/AddDiscriminators/diamond.ll Wed Jun 15 16:51:30 2016<br>
> @@ -1,4 +1,5 @@<br>
> ; RUN: opt < %s -add-discriminators -S | FileCheck %s<br>
> +; RUN: opt < %s -passes=add-discriminators -S | FileCheck %s<br>
><br>
> ; Discriminator support for diamond-shaped CFG.:<br>
> ; #1 void bar(int);<br>
><br>
> Modified: llvm/trunk/test/Transforms/AddDiscriminators/first-only.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/first-only.ll?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/first-only.ll?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/AddDiscriminators/first-only.ll (original)<br>
> +++ llvm/trunk/test/Transforms/AddDiscriminators/first-only.ll Wed Jun 15 16:51:30 2016<br>
> @@ -1,4 +1,5 @@<br>
> ; RUN: opt < %s -add-discriminators -S | FileCheck %s<br>
> +; RUN: opt < %s -passes=add-discriminators -S | FileCheck %s<br>
><br>
> ; Test that the only instructions that receive a new discriminator in<br>
> ; the block 'if.then' are those that share the same line number as<br>
><br>
> Modified: llvm/trunk/test/Transforms/AddDiscriminators/multiple.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/multiple.ll?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/multiple.ll?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/AddDiscriminators/multiple.ll (original)<br>
> +++ llvm/trunk/test/Transforms/AddDiscriminators/multiple.ll Wed Jun 15 16:51:30 2016<br>
> @@ -1,4 +1,5 @@<br>
> ; RUN: opt < %s -add-discriminators -S | FileCheck %s<br>
> +; RUN: opt < %s -passes=add-discriminators -S | FileCheck %s<br>
><br>
> ; Discriminator support for multiple CFG paths on the same line.<br>
> ;<br>
><br>
> Modified: llvm/trunk/test/Transforms/AddDiscriminators/no-discriminators.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/no-discriminators.ll?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/no-discriminators.ll?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/AddDiscriminators/no-discriminators.ll (original)<br>
> +++ llvm/trunk/test/Transforms/AddDiscriminators/no-discriminators.ll Wed Jun 15 16:51:30 2016<br>
> @@ -1,4 +1,5 @@<br>
> ; RUN: opt < %s -add-discriminators -S | FileCheck %s<br>
> +; RUN: opt < %s -passes=add-discriminators -S | FileCheck %s<br>
><br>
> ; We should not generate discriminators for DWARF versions prior to 4.<br>
> ;<br>
><br>
> Modified: llvm/trunk/test/Transforms/AddDiscriminators/oneline.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/oneline.ll?rev=272847&r1=272846&r2=272847&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/AddDiscriminators/oneline.ll?rev=272847&r1=272846&r2=272847&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/Transforms/AddDiscriminators/oneline.ll (original)<br>
> +++ llvm/trunk/test/Transforms/AddDiscriminators/oneline.ll Wed Jun 15 16:51:30 2016<br>
> @@ -1,4 +1,5 @@<br>
> ; RUN: opt < %s -add-discriminators -S | FileCheck %s<br>
> +; RUN: opt < %s -passes=add-discriminators -S | FileCheck %s<br>
><br>
> ; Discriminator support for code that is written in one line:<br>
> ; #1 int foo(int i) {<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</font></span></blockquote></div><br></div>