<div dir="ltr">A small example of the issue here is:<div><br></div><div>```</div><div><div>namespace foo {</div><div>class Foo {</div><div>  class Contained {</div><div>    int x;</div><div>  };</div><div>  </div><div>  friend void bar(Foo::Contained &);</div><div>};</div><div>// Is this needed? GCC and ICC think so. Clang disagrees.</div><div>//void bar(Foo::Contained &);</div><div>}</div><div><br></div><div>void foo::bar(Foo::Contained &) {</div><div>}</div><div>```</div><div><br></div><div>Testing a couple compilers at <a href="https://godbolt.org/g/kNmQhB">https://godbolt.org/g/kNmQhB</a> it seems like clang does not need the extra declaration inside the namespace but gcc and icc do.</div><div><br></div><div>I think it is this question also: <a href="http://stackoverflow.com/questions/16718166/friend-function-declaration-definition-inside-a-namespace">http://stackoverflow.com/questions/16718166/friend-function-declaration-definition-inside-a-namespace</a></div></div><div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 15, 2016 at 2:00 AM, Sean Silva via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: silvas<br>
Date: Wed Jun 15 04:00:33 2016<br>
New Revision: 272767<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=272767&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=272767&view=rev</a><br>
Log:<br>
Speculative buildbot fix.<br>
<br>
This wasn't failing for me with clang as the compiler. I think GCC may<br>
disagree with clang about whether a friend declaration introduces a<br>
declaration in the enclosing namespace (or something).<br>
<br>
Example error:<br>
<br>
/home/uweigand/sandbox/buildbot/clang-s390x-linux/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:950:77: error: ‘llvm::raw_ostream& llvm::slpvectorizer::operator<<(llvm::raw_ostream&, const llvm::slpvectorizer::BoUpSLP::ScheduleData&)’ should have been declared inside ‘llvm::slpvectorizer’<br>
                                              const BoUpSLP::ScheduleData &SD) {<br>
                                                                             ^<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=272767&r1=272766&r2=272767&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=272767&r1=272766&r2=272767&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp Wed Jun 15 04:00:33 2016<br>
@@ -942,6 +942,11 @@ private:<br>
   /// can legally be represented.<br>
   MapVector<Value *, uint64_t> MinBWs;<br>
 };<br>
+<br>
+#ifndef NDEBUG<br>
+raw_ostream &operator<<(raw_ostream &os, const BoUpSLP::ScheduleData &SD);<br>
+#endif<br>
+<br>
 } // end namespace llvm<br>
 } // end namespace slpvectorizer<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>