<div dir="ltr">Hmm - I thought we had an actual warning for this? Am I remembering correctly? Could we turn it on for LLVM's build?</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jun 12, 2016 at 12:02 PM, Benjamin Kramer via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Sun Jun 12 14:02:34 2016<br>
New Revision: 272519<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=272519&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=272519&view=rev</a><br>
Log:<br>
Use 'auto' to avoid implicit copies.<br>
<br>
td_type is std::pair<std::string, std::string>, but the map returns<br>
elements of std::pair<const std::string, std::string>. In well-designed<br>
languages like C++ that yields an implicit copy perfectly hidden by<br>
constref's lifetime extension. Just use auto, the typedef obscured the<br>
real type anyways.<br>
<br>
Found with a little help from clang-tidy's<br>
performance-implicit-cast-in-loop.<br>
<br>
Modified:<br>
    llvm/trunk/lib/IR/Attributes.cpp<br>
<br>
Modified: llvm/trunk/lib/IR/Attributes.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Attributes.cpp?rev=272519&r1=272518&r2=272519&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Attributes.cpp?rev=272519&r1=272518&r2=272519&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/IR/Attributes.cpp (original)<br>
+++ llvm/trunk/lib/IR/Attributes.cpp Sun Jun 12 14:02:34 2016<br>
@@ -792,7 +792,7 @@ AttributeSet AttributeSet::get(LLVMConte<br>
   }<br>
<br>
   // Add target-dependent (string) attributes.<br>
-  for (const AttrBuilder::td_type &TDA : B.td_attrs())<br>
+  for (const auto &TDA : B.td_attrs())<br>
     Attrs.push_back(<br>
         std::make_pair(Index, Attribute::get(C, TDA.first, TDA.second)));<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>