<p dir="ltr">Sounds reasonable, but why not return a SubtargetFeatures?</p>
<div class="gmail_quot<blockquote class=" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">dsanders created this revision.<br>
dsanders added a subscriber: llvm-commits.<br>
Herald added subscribers: sdardis, dsanders.<br>
<br>
The Mips implementation only covers the feature bits described by the ELF<br>
e_flags so far. Mips stores additional feature bits such as MSA in the<br>
.MIPS.abiflags section.<br>
<br>
Also fixed a small bug this revealed where microMIPS wouldn't add the<br>
EF_MIPS_MICROMIPS flag when using -filetype=obj.<br>
<br>
<a href="http://reviews.llvm.org/D21125" rel="noreferrer" target="_blank">http://reviews.llvm.org/D21125</a><br>
<br>
Files:<br>
  include/llvm/Object/COFF.h<br>
  include/llvm/Object/ELFObjectFile.h<br>
  include/llvm/Object/MachO.h<br>
  include/llvm/Object/ObjectFile.h<br>
  include/llvm/Support/ELF.h<br>
  lib/Target/Mips/MipsAsmPrinter.cpp<br>
  test/CodeGen/Mips/Fast-ISel/shift.ll<br>
  test/CodeGen/Mips/compactbranches/no-beqzc-bnezc.ll<br>
  test/CodeGen/Mips/micromips-atomic1.ll<br>
  test/MC/Mips/cpload.s<br>
  test/MC/Mips/cprestore-noreorder-noat.s<br>
  test/MC/Mips/cprestore-noreorder.s<br>
  test/MC/Mips/cprestore-reorder.s<br>
  test/MC/Mips/cpsetup.s<br>
  test/MC/Mips/micromips-el-fixup-data.s<br>
  test/MC/Mips/mips64extins.s<br>
  test/MC/Mips/mips_gprel16.s<br>
  test/MC/Mips/set-defined-symbol.s<br>
  test/Object/Mips/feature.test<br>
  test/Object/Mips/objdump-micro-mips.test<br>
  tools/llvm-objdump/llvm-objdump.cpp<br>
<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></div>