<div dir="ltr">Should be fixed in r272147.<div><br></div><div>Sorry for all the churn, I guess it was naive of me to expect I could land this without testing Windows directly.</div><div><br></div><div> - Daniel</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 7, 2016 at 9:59 PM, Yaron Keren <span dir="ltr"><<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="rtl"><div dir="ltr">See the bots here:</div><div dir="ltr"><br></div><div dir="ltr"><a href="http://bb.pgr.jp/builders/ninja-clang-i686-msc19-R/builds/3811/steps/test-llvm" target="_blank">http://bb.pgr.jp/builders/ninja-clang-i686-msc19-R/builds/3811/steps/test-llvm</a><br></div><div dir="ltr"><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><div dir="ltr"><br><div class="gmail_quote">2016-06-08 7:57 GMT+03:00 Yaron Keren <span dir="ltr"><<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 .8ex;border-left:1px #ccc solid;border-right:1px #ccc solid;padding-left:1ex;padding-right:1ex"><div dir="rtl"><div dir="ltr">Now it errors on "AttributeError: 'str' object has no attribute 'decode'" in the same location.</div><div><div><div dir="ltr"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><div dir="ltr">2016-06-08 1:14 GMT+03:00 Daniel Dunbar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span>:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Fixed in r272066.</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 7, 2016 at 3:06 PM, Michael Spencer <span dir="ltr"><<a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>On Tue, Jun 7, 2016 at 1:14 PM, Daniel Dunbar via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: ddunbar<br>
> Date: Tue Jun 7 15:14:17 2016<br>
> New Revision: 272052<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=272052&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=272052&view=rev</a><br>
> Log:<br>
> [lit] Fix an uninitialized var on Windows.<br>
><br>
> Modified:<br>
> llvm/trunk/utils/lit/lit/TestRunner.py<br>
><br>
> Modified: llvm/trunk/utils/lit/lit/TestRunner.py<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=272052&r1=272051&r2=272052&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=272052&r1=272051&r2=272052&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/utils/lit/lit/TestRunner.py (original)<br>
> +++ llvm/trunk/utils/lit/lit/TestRunner.py Tue Jun 7 15:14:17 2016<br>
> @@ -255,6 +255,7 @@ def _executeShCmd(cmd, shenv, results, t<br>
> result = subprocess.PIPE<br>
> else:<br>
> if r[2] is None:<br>
> + redir_filename = None<br>
> if kAvoidDevNull and r[0] == '/dev/null':<br>
> r[2] = tempfile.TemporaryFile(mode=r[1])<br>
> elif kIsWindows and r[0] == '/dev/tty':<br>
> @@ -398,7 +399,7 @@ def _executeShCmd(cmd, shenv, results, t<br>
> # Gather the redirected output files.<br>
> output_files = []<br>
> for (name, mode, f, path) in sorted(opened_files):<br>
> - if mode in ('w', 'a'):<br>
> + if path is not None and mode in ('w', 'a'):<br>
> try:<br>
> with open(path) as f:<br>
> data = f.read()<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
</div></div>Now getting:<br>
<br>
******************** TEST 'LLVM :: Linker/2009-09-03-mdnode.ll' FAILED<br>
********************<br>
Exception during script execution:<br>
Traceback (most recent call last):<br>
File "C:\llvm\utils\lit\lit\run.py", line 168, in execute_test<br>
result = test.config.test_format.execute(test, self.lit_config)<br>
File "C:\llvm\utils\lit\lit\formats\shtest.py", line 12, in execute<br>
self.execute_external)<br>
File "C:\llvm\utils\lit\lit\TestRunner.py", line 832, in executeShTest<br>
res = _runShTest(test, litConfig, useExternalSh, script, tmpBase)<br>
File "C:\llvm\utils\lit\lit\TestRunner.py", line 780, in _runShTest<br>
res = executeScriptInternal(test, litConfig, tmpBase, script, execdir)<br>
File "C:\llvm\utils\lit\lit\TestRunner.py", line 479, in executeScriptInternal<br>
data = to_string(data.decode('utf-8'))<br>
File "C:\Python27\lib\encodings\utf_8.py", line 16, in decode<br>
return codecs.utf_8_decode(input, errors, True)<br>
UnicodeDecodeError: 'utf8' codec can't decode byte 0xc0 in position 2:<br>
invalid start byte<br>
<span><font color="#888888"><br>
- Michael Spencer<br>
</font></span></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div></div></div>
</blockquote></div></div></div>
</div></div></blockquote></div><br></div>