<div dir="ltr">Does this require loading the GNUInstallDirs cmake module?</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 7, 2016 at 2:11 PM, Chris Bieneman via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Should have mentioned in the commit message this broke a bot:<br>
<a href="http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/38387/steps/recheck_cmake/logs/stdio" rel="noreferrer" target="_blank">http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/38387/steps/recheck_cmake/logs/stdio</a><br>
<br>
I’ll work on coming up with a fix.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Chris<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> On Jun 7, 2016, at 11:04 AM, Chris Bieneman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: cbieneman<br>
> Date: Tue Jun  7 13:04:37 2016<br>
> New Revision: 272033<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=272033&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=272033&view=rev</a><br>
> Log:<br>
> Revert "Use CMAKE_INSTALL_BINDIR instead of hardcoding bin for tools install paths"<br>
><br>
> This reverts commit 0dc5a55f66ed06d7859c4e0474a87428d27775e6.<br>
><br>
> Modified:<br>
>    llvm/trunk/cmake/modules/AddLLVM.cmake<br>
>    llvm/trunk/cmake/modules/TableGen.cmake<br>
><br>
> Modified: llvm/trunk/cmake/modules/AddLLVM.cmake<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=272033&r1=272032&r2=272033&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=272033&r1=272032&r2=272033&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/cmake/modules/AddLLVM.cmake (original)<br>
> +++ llvm/trunk/cmake/modules/AddLLVM.cmake Tue Jun  7 13:04:37 2016<br>
> @@ -771,7 +771,7 @@ macro(add_llvm_tool name)<br>
>     if( LLVM_BUILD_TOOLS )<br>
>       install(TARGETS ${name}<br>
>               EXPORT LLVMExports<br>
> -              RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}<br>
> +              RUNTIME DESTINATION bin<br>
>               COMPONENT ${name})<br>
><br>
>       if (NOT CMAKE_CONFIGURATION_TYPES)<br>
> @@ -1211,7 +1211,7 @@ function(llvm_install_symlink name dest)<br>
>   set(full_dest ${dest}${CMAKE_EXECUTABLE_SUFFIX})<br>
><br>
>   install(SCRIPT ${INSTALL_SYMLINK}<br>
> -          CODE "install_symlink(${full_name} ${full_dest} ${CMAKE_INSTALL_BINDIR})"<br>
> +          CODE "install_symlink(${full_name} ${full_dest} bin)"<br>
>           COMPONENT ${component})<br>
><br>
>   if (NOT CMAKE_CONFIGURATION_TYPES AND NOT ARG_ALWAYS_GENERATE)<br>
><br>
> Modified: llvm/trunk/cmake/modules/TableGen.cmake<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/TableGen.cmake?rev=272033&r1=272032&r2=272033&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/TableGen.cmake?rev=272033&r1=272032&r2=272033&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/cmake/modules/TableGen.cmake (original)<br>
> +++ llvm/trunk/cmake/modules/TableGen.cmake Tue Jun  7 13:04:37 2016<br>
> @@ -141,7 +141,7 @@ macro(add_tablegen target project)<br>
>   if (${project} STREQUAL LLVM AND NOT LLVM_INSTALL_TOOLCHAIN_ONLY)<br>
>     install(TARGETS ${target}<br>
>             EXPORT LLVMExports<br>
> -            RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})<br>
> +            RUNTIME DESTINATION bin)<br>
>   endif()<br>
>   set_property(GLOBAL APPEND PROPERTY LLVM_EXPORTS ${target})<br>
> endmacro()<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>