<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Yes, but I’m not sure that’s the correct solution. I’m iterating off list with the person who proposed the original patch.<div class=""><br class=""></div><div class="">The approach I’m proposing is here -> <a href="http://reviews.llvm.org/P4915" class="">http://reviews.llvm.org/P4915</a></div><div class=""><br class=""></div><div class="">-Chris</div><div class=""><br class=""><div class=""><div><blockquote type="cite" class=""><div class="">On Jun 7, 2016, at 1:39 PM, Keno Fischer <<a href="mailto:keno@juliacomputing.com" class="">keno@juliacomputing.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Does this require loading the GNUInstallDirs cmake module?</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Jun 7, 2016 at 2:11 PM, Chris Bieneman via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Should have mentioned in the commit message this broke a bot:<br class="">
<a href="http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/38387/steps/recheck_cmake/logs/stdio" rel="noreferrer" target="_blank" class="">http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/38387/steps/recheck_cmake/logs/stdio</a><br class="">
<br class="">
I’ll work on coming up with a fix.<br class="">
<span class="HOEnZb"><font color="#888888" class=""><br class="">
-Chris<br class="">
</font></span><div class="HOEnZb"><div class="h5"><br class="">
> On Jun 7, 2016, at 11:04 AM, Chris Bieneman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Author: cbieneman<br class="">
> Date: Tue Jun 7 13:04:37 2016<br class="">
> New Revision: 272033<br class="">
><br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=272033&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=272033&view=rev</a><br class="">
> Log:<br class="">
> Revert "Use CMAKE_INSTALL_BINDIR instead of hardcoding bin for tools install paths"<br class="">
><br class="">
> This reverts commit 0dc5a55f66ed06d7859c4e0474a87428d27775e6.<br class="">
><br class="">
> Modified:<br class="">
> llvm/trunk/cmake/modules/AddLLVM.cmake<br class="">
> llvm/trunk/cmake/modules/TableGen.cmake<br class="">
><br class="">
> Modified: llvm/trunk/cmake/modules/AddLLVM.cmake<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=272033&r1=272032&r2=272033&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=272033&r1=272032&r2=272033&view=diff</a><br class="">
> ==============================================================================<br class="">
> --- llvm/trunk/cmake/modules/AddLLVM.cmake (original)<br class="">
> +++ llvm/trunk/cmake/modules/AddLLVM.cmake Tue Jun 7 13:04:37 2016<br class="">
> @@ -771,7 +771,7 @@ macro(add_llvm_tool name)<br class="">
> if( LLVM_BUILD_TOOLS )<br class="">
> install(TARGETS ${name}<br class="">
> EXPORT LLVMExports<br class="">
> - RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}<br class="">
> + RUNTIME DESTINATION bin<br class="">
> COMPONENT ${name})<br class="">
><br class="">
> if (NOT CMAKE_CONFIGURATION_TYPES)<br class="">
> @@ -1211,7 +1211,7 @@ function(llvm_install_symlink name dest)<br class="">
> set(full_dest ${dest}${CMAKE_EXECUTABLE_SUFFIX})<br class="">
><br class="">
> install(SCRIPT ${INSTALL_SYMLINK}<br class="">
> - CODE "install_symlink(${full_name} ${full_dest} ${CMAKE_INSTALL_BINDIR})"<br class="">
> + CODE "install_symlink(${full_name} ${full_dest} bin)"<br class="">
> COMPONENT ${component})<br class="">
><br class="">
> if (NOT CMAKE_CONFIGURATION_TYPES AND NOT ARG_ALWAYS_GENERATE)<br class="">
><br class="">
> Modified: llvm/trunk/cmake/modules/TableGen.cmake<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/TableGen.cmake?rev=272033&r1=272032&r2=272033&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/TableGen.cmake?rev=272033&r1=272032&r2=272033&view=diff</a><br class="">
> ==============================================================================<br class="">
> --- llvm/trunk/cmake/modules/TableGen.cmake (original)<br class="">
> +++ llvm/trunk/cmake/modules/TableGen.cmake Tue Jun 7 13:04:37 2016<br class="">
> @@ -141,7 +141,7 @@ macro(add_tablegen target project)<br class="">
> if (${project} STREQUAL LLVM AND NOT LLVM_INSTALL_TOOLCHAIN_ONLY)<br class="">
> install(TARGETS ${target}<br class="">
> EXPORT LLVMExports<br class="">
> - RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})<br class="">
> + RUNTIME DESTINATION bin)<br class="">
> endif()<br class="">
> set_property(GLOBAL APPEND PROPERTY LLVM_EXPORTS ${target})<br class="">
> endmacro()<br class="">
><br class="">
><br class="">
> _______________________________________________<br class="">
> llvm-commits mailing list<br class="">
> <a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></div></body></html>