<div dir="ltr">It would be good to at least send a fresh mail to the list with an updated rationale and such.<div><br></div><div>One thing that I'm having trouble even making out from the patch description in Phab is exactly what numbers you have collected. The formatting makes it really hard to understand what change this actually introduces.</div><div><br></div><div>As one high-level comment, why would we want this *and* ADCE to exist? I feel like we don't need 4 or 5 different dead code elimination passes and would benefit from this actually just being a patch to one of the existing ones.</div><div><br></div><div>Another high-level comment: if we must have both ADCE and this pass, I find the name "ACDCE" or "Aggressive Control Dead Code Elimination" very confusing. The order of the words seems all wrong. If we need to distinguish between eliminating dead control flows independent of eliminating dead instructions within basic blocks, I would name them "Aggressive Dead Control Flow Elimination" and "Aggressive Dead Code Elimination". And I would consider stripping the "Aggressive" prefix because I doubt that really makes sense these days.</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jun 6, 2016 at 2:11 PM David Callahan via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">david2050 updated this revision to Diff 59782.<br>
david2050 added a comment.<br>
<br>
- Merge branch 'master' into acdce-with-idf-for-review<br>
<br>
<br>
<a href="http://reviews.llvm.org/D18762" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18762</a><br>
<br>
Files:<br>
include/llvm/InitializePasses.h<br>
include/llvm/LinkAllPasses.h<br>
include/llvm/Transforms/Scalar.h<br>
include/llvm/Transforms/Scalar/ACDCE.h<br>
lib/Passes/PassBuilder.cpp<br>
lib/Passes/PassRegistry.def<br>
lib/Transforms/IPO/PassManagerBuilder.cpp<br>
lib/Transforms/Scalar/ACDCE.cpp<br>
lib/Transforms/Scalar/CMakeLists.txt<br>
lib/Transforms/Scalar/Scalar.cpp<br>
test/Transforms/ADCE/2002-01-31-UseStuckAround.ll<br>
test/Transforms/ADCE/2002-05-22-PHITest.ll<br>
test/Transforms/ADCE/2002-05-23-ZeroArgPHITest.ll<br>
test/Transforms/ADCE/2002-05-28-Crash-distilled.ll<br>
test/Transforms/ADCE/2002-05-28-Crash.ll<br>
test/Transforms/ADCE/2002-07-17-AssertionFailure.ll<br>
test/Transforms/ADCE/2002-07-17-PHIAssertion.ll<br>
test/Transforms/ADCE/2002-07-29-Segfault.ll<br>
test/Transforms/ADCE/2003-01-22-PredecessorProblem.ll<br>
test/Transforms/ADCE/2003-04-25-PHIPostDominateProblem.ll<br>
test/Transforms/ADCE/2003-06-11-InvalidCFG.ll<br>
test/Transforms/ADCE/2003-06-24-BadSuccessor.ll<br>
test/Transforms/ADCE/2003-06-24-BasicFunctionality.ll<br>
test/Transforms/ADCE/2003-09-10-UnwindInstFail.ll<br>
test/Transforms/ADCE/2003-09-15-InfLoopCrash.ll<br>
test/Transforms/ADCE/2003-11-16-MissingPostDominanceInfo.ll<br>
test/Transforms/ADCE/2004-05-04-UnreachableBlock.ll<br>
test/Transforms/ADCE/2005-02-17-PHI-Invoke-Crash.ll<br>
test/Transforms/ADCE/basictest.ll<br>
test/Transforms/ADCE/basictest1.ll<br>
test/Transforms/ADCE/basictest2.ll<br>
test/Transforms/ADCE/debug-info-intrinsic.ll<br>
test/Transforms/ADCE/delete-profiling-calls-to-constant.ll<br>
test/Transforms/ADCE/unreachable-function.ll<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>