<div dir="ltr">Just FYI for context:<br><br><div class="gmail_quote"><div dir="ltr">On Mon, Jun 6, 2016 at 12:27 PM Davide Italiano via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">davide created this revision.<br>
davide added reviewers: chandlerc, bogner, sanjoy.<br>
davide added a subscriber: llvm-commits.<br>
<br>
Not sure if this is just an oversight, or there's a real reason why we don't want to cache DominatorTree and GlobalsAA when the IR is mutated as the old PM does. Thanks!<br></blockquote><div><br></div><div>Just oversight. Thanks!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<a href="http://reviews.llvm.org/D21035" rel="noreferrer" target="_blank">http://reviews.llvm.org/D21035</a><br>
<br>
Files:<br>
  lib/Transforms/Scalar/GVN.cpp<br>
<br>
Index: lib/Transforms/Scalar/GVN.cpp<br>
===================================================================<br>
--- lib/Transforms/Scalar/GVN.cpp<br>
+++ lib/Transforms/Scalar/GVN.cpp<br>
@@ -594,7 +594,12 @@<br>
   auto &AA = AM.getResult<AAManager>(F);<br>
   auto &MemDep = AM.getResult<MemoryDependenceAnalysis>(F);<br>
   bool Changed = runImpl(F, AC, DT, TLI, AA, &MemDep);<br>
-  return Changed ? PreservedAnalyses::none() : PreservedAnalyses::all();<br>
+  if (!Changed)<br>
+    return PreservedAnalyses::all();<br>
+  PreservedAnalyses PA;<br>
+  PA.preserve<DominatorTreeAnalysis>();<br>
+  PA.preserve<GlobalsAA>();<br>
+  return PA;<br>
 }<br>
<br>
 #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>