<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Hi Zan Jyu,</div><div class=""><br class=""></div>Yep.<div class=""><br class=""></div><div class="">Do you have a test case to put with that?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">-Quentin<br class=""><div><blockquote type="cite" class=""><div class="">On Jun 7, 2016, at 12:25 AM, zan jyu Wong via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_default" style="font-family:monospace,monospace;font-size:large">We should test isReg() before isDef()<br class=""><br class="">diff --git a/lib/CodeGen/MachineLICM.cpp b/lib/CodeGen/MachineLICM.cpp<br class="">index 00dec82..4ea0c56 100644<br class="">--- a/lib/CodeGen/MachineLICM.cpp<br class="">+++ b/lib/CodeGen/MachineLICM.cpp<br class="">@@ -716,7 +716,7 @@ void MachineLICM::SinkIntoLoop() {<br class=""> <br class=""> for (MachineInstr *I : Candidates) {<br class=""> const MachineOperand &MO = I->getOperand(0);<br class="">- if (!MO.isDef() || !MO.isReg() || !MO.getReg())<br class="">+ if (!MO.isReg() || !MO.isDef() || !MO.getReg())<br class=""> continue;<br class=""> if (!MRI->hasOneDef(MO.getReg()))<br class=""> continue;<br class=""></div></div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></div></body></html>