<div dir="ltr">Thanks! I have a feeling that this was the issue that was causing Chromium's LLD bot to fail.<div><a href="https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxLLD">https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxLLD</a><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Can you please check in a script that can recreate the version-use.so file?</div><div class="gmail_extra"><br></div><div class="gmail_extra">Peter</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 6, 2016 at 3:42 PM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Mon Jun  6 17:42:57 2016<br>
New Revision: 271950<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=271950&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=271950&view=rev</a><br>
Log:<br>
Ignore the "globally available" version.<br>
<br>
Reduced from a firefox build.<br>
<br>
Added:<br>
    lld/trunk/test/ELF/Inputs/version-use.script<br>
    lld/trunk/test/ELF/Inputs/version-use.so   (with props)<br>
    lld/trunk/test/ELF/version-use.s<br>
Modified:<br>
    lld/trunk/ELF/InputFiles.cpp<br>
<br>
Modified: lld/trunk/ELF/InputFiles.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=271950&r1=271949&r2=271950&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=271950&r1=271949&r2=271950&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/InputFiles.cpp (original)<br>
+++ lld/trunk/ELF/InputFiles.cpp Mon Jun  6 17:42:57 2016<br>
@@ -527,7 +527,7 @@ template <class ELFT> void SharedFile<EL<br>
<br>
     if (Versym) {<br>
       // Ignore local symbols and non-default versions.<br>
-      if (VersymIndex == 0 || (VersymIndex & VERSYM_HIDDEN))<br>
+      if (VersymIndex == 0 || VersymIndex == 1 || (VersymIndex & VERSYM_HIDDEN))<br>
         continue;<br>
     }<br>
     elf::Symtab<ELFT>::X->addShared(this, Name, Sym, Verdefs[VersymIndex]);<br>
<br>
Added: lld/trunk/test/ELF/Inputs/version-use.script<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/version-use.script?rev=271950&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/version-use.script?rev=271950&view=auto</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/Inputs/version-use.script (added)<br>
+++ lld/trunk/test/ELF/Inputs/version-use.script Mon Jun  6 17:42:57 2016<br>
@@ -0,0 +1,6 @@<br>
+ABC {<br>
+global:<br>
+foo;<br>
+local:<br>
+*;<br>
+};<br>
<br>
Added: lld/trunk/test/ELF/Inputs/version-use.so<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/version-use.so?rev=271950&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/version-use.so?rev=271950&view=auto</a><br>
==============================================================================<br>
Binary files lld/trunk/test/ELF/Inputs/version-use.so (added) and lld/trunk/test/ELF/Inputs/version-use.so Mon Jun  6 17:42:57 2016 differ<br>
<br>
Propchange: lld/trunk/test/ELF/Inputs/version-use.so<br>
------------------------------------------------------------------------------<br>
    svn:executable = *<br>
<br>
Added: lld/trunk/test/ELF/version-use.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/version-use.s?rev=271950&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/version-use.s?rev=271950&view=auto</a><br>
==============================================================================<br>
--- lld/trunk/test/ELF/version-use.s (added)<br>
+++ lld/trunk/test/ELF/version-use.s Mon Jun  6 17:42:57 2016<br>
@@ -0,0 +1,9 @@<br>
+// REQUIRES: x86<br>
+// RUN: llvm-mc %s -o %t.o -filetype=obj -triple=x86_64-pc-linux<br>
+// RUN: ld.lld %t.o %p/Inputs/version-use.so -o %t.so -shared<br>
+// RUN: llvm-readobj -s %t.so | FileCheck %s<br>
+<br>
+<br>
+        call    bar@PLT<br>
+<br>
+// CHECK-NOT: SHT_GNU_versym<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div></div>