I thought so, but if not ignore that comment <br><div class="gmail_quote"><div dir="ltr">On Sun, Jun 5, 2016 at 11:52 AM Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ruiu added inline comments.<br>
<br>
================<br>
Comment at: include/llvm/DebugInfo/PDB/Raw/RawTypes.h:83<br>
@@ -82,1 +82,3 @@<br>
<br>
+// Corresponds to `_FPO_DATA` structure in the PE/COFF spec.<br>
+struct FpoData {<br>
----------------<br>
zturner wrote:<br>
> Do you think this should go in `llvm/Support/COFF.h` (or is it perhaps there already?)<br>
Done.<br>
<br>
================<br>
Comment at: lib/DebugInfo/PDB/Raw/DbiStream.cpp:313-314<br>
@@ +312,4 @@<br>
+<br>
+  size_t StreamLen = FpoStream->getLength();<br>
+  size_t NumRecords = StreamLen / sizeof(FpoData);<br>
+  codeview::StreamReader Reader(*FpoStream);<br>
----------------<br>
majnemer wrote:<br>
> Should we check that StreamLen is a multiple of sizeof(FpoData)?<br>
I think readArray takes care of it.<br>
<br>
================<br>
Comment at: tools/llvm-pdbdump/LLVMOutputStyle.cpp:691-692<br>
@@ +690,4 @@<br>
+    P.printNumber("Number of Saved Registers", Fpo.getNumSavedRegs());<br>
+    P.printNumber("Has SEH", Fpo.hasSEH());<br>
+    P.printNumber("Use BP", Fpo.useBP());<br>
+    P.printNumber("Frame Pointer", Fpo.getFP());<br>
----------------<br>
majnemer wrote:<br>
> Shouldn't these be printed as booleans?<br>
Done.<br>
<br>
================<br>
Comment at: tools/llvm-pdbdump/LLVMOutputStyle.h:36<br>
@@ -35,2 +35,3 @@<br>
   Error dumpSectionHeaders() override;<br>
+  Error dumpFpoStream() override;<br>
<br>
----------------<br>
zturner wrote:<br>
> You will probably need to update `YamlOutputStyle.h` as well, you can just have the method do nothing.<br>
Did you submit YamlOutputStyle.h already?<br>
<br>
<br>
<a href="http://reviews.llvm.org/D20999" rel="noreferrer" target="_blank">http://reviews.llvm.org/D20999</a><br>
<br>
<br>
<br>
</blockquote></div>