<div dir="ltr">My only concern would maybe be verbosity (sometimes the input could be quite large and drown out everything else). But overall this solves an issue that I've run into too.<div><br></div><div>I would also suggest to print something more clear like "Begin FileCheck Input: *********" << .... << "End FileCheck Input: *********" to distinguish it from the surrounding and be easy to search for (in case of a very large input).<div><div><br></div><div>-- Sean Silva</div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 2, 2016 at 10:46 AM, Dmitry Vyukov via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">dvyukov created this revision.<br>
dvyukov added a reviewer: llvm-commits.<br>
<br>
FileCheck output is unactionable without intput. Print input on errors.<br>
<br>
Are there any downsides of this?<br>
I am ready to bargain about details like output only stdin.<br>
<br>
<br>
<br>
<a href="http://reviews.llvm.org/D20925" rel="noreferrer" target="_blank">http://reviews.llvm.org/D20925</a><br>
<br>
Files:<br>
utils/FileCheck/FileCheck.cpp<br>
<br>
Index: utils/FileCheck/FileCheck.cpp<br>
===================================================================<br>
--- utils/FileCheck/FileCheck.cpp<br>
+++ utils/FileCheck/FileCheck.cpp<br>
@@ -1407,5 +1407,8 @@<br>
break;<br>
}<br>
<br>
+ if (hasError)<br>
+ errs() << "Input:" << '\n' << Buffer.str() << '\n';<br>
+<br>
return hasError ? 1 : 0;<br>
}<br>
<br>
<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>