<div dir="ltr">I added comments and committed r271582.<div><br></div><div>thanks,</div><div><br></div><div>David</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 2, 2016 at 1:28 PM, Chris Bieneman <span dir="ltr"><<a href="mailto:beanz@apple.com" target="_blank">beanz@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">David,<div><br></div><div>Please commit that patch with a comment about what it is fixing. I suspect we’ll want to fix that in a different way eventually, but it may take some time to work that out and fixing the broken build is important.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-Chris</div></font></span><div><div class="h5"><div><br><div><blockquote type="cite"><div>On Jun 2, 2016, at 1:15 PM, Xinliang David Li <<a href="mailto:xinliangli@gmail.com" target="_blank">xinliangli@gmail.com</a>> wrote:</div><br><div><div dir="ltr"><div><br></div>The following patch fixes the problem. With this patch, ninja check-profile reports success with 129 passes. <div><br></div><div>Can you check if it is the right fix?</div><div><br></div><div>David<br><div><br></div><div><br></div><div><div>Index: CMakeLists.txt</div><div>===================================================================</div><div>--- CMakeLists.txt (revision 271566)</div><div>+++ CMakeLists.txt (working copy)</div><div>@@ -16,6 +16,7 @@ else()</div><div> endif()</div><div> </div><div> cmake_minimum_required(VERSION 3.4.3)</div><div>+cmake_policy(SET CMP0056 OLD) </div><div> </div><div> # FIXME: It may be removed when we use 2.8.12.</div><div> if(CMAKE_VERSION VERSION_LESS 2.8.12)</div><div><br></div></div><div><br></div><div><br><div><br></div><div><br></div><div><br></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 2, 2016 at 12:00 PM, Xinliang David Li <span dir="ltr"><<a href="mailto:xinliangli@gmail.com" target="_blank">xinliangli@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Chris, this change seems to have broken compiler_rt testing's coverage. WIth this change, PROFILE_SUPPORTED_ARCH is no longer properly defined. On X86_64, it is defined to be X86_64 while before this change, it was set to X86_64, i386 and i686. The errors I got:<div><br></div><div><div>cannot open ... ../lib/clang/3.9.0/lib/linux/libclang_rt.profile-i386.a: No such file or directory</div><div><br></div><div><br></div><div>sanitizer testing seems to be affected too -- no failures, but the number of tests is reduced.</div></div><div><br></div><div>Can you take a look?</div><span><font color="#888888"><div><br></div><div>David</div><div><br></div></font></span></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 31, 2016 at 1:21 PM, Chris Bieneman via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: cbieneman<br>
Date: Tue May 31 15:21:42 2016<br>
New Revision: 271327<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=271327&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=271327&view=rev</a><br>
Log:<br>
[CMake] Update to requiring CMake 3.4.3<br>
<br>
Summary:<br>
This is as per the discussions on developer lists:<br>
<br>
<a href="http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html" rel="noreferrer" target="_blank">http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html</a><br>
<a href="http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html" rel="noreferrer" target="_blank">http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html</a><br>
<br>
Subscribers: llvm-commits<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D20824" rel="noreferrer" target="_blank">http://reviews.llvm.org/D20824</a><br>
<br>
Modified:<br>
compiler-rt/trunk/CMakeLists.txt<br>
compiler-rt/trunk/lib/builtins/CMakeLists.txt<br>
<br>
Modified: compiler-rt/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=271327&r1=271326&r2=271327&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=271327&r1=271326&r2=271327&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/CMakeLists.txt (original)<br>
+++ compiler-rt/trunk/CMakeLists.txt Tue May 31 15:21:42 2016<br>
@@ -15,16 +15,7 @@ else()<br>
set(COMPILER_RT_STANDALONE_BUILD FALSE)<br>
endif()<br>
<br>
-# The CompilerRT build system requires CMake version 2.8.8 or higher in order<br>
-# to use its support for building convenience "libraries" as a collection of<br>
-# .o files. This is particularly useful in producing larger, more complex<br>
-# runtime libraries.<br>
-if (NOT MSVC)<br>
- cmake_minimum_required(VERSION 2.8.8)<br>
-else()<br>
- # Version 2.8.12.1 is required to build with Visual Studio 2013.<br>
- cmake_minimum_required(VERSION 2.8.12.1)<br>
-endif()<br>
+cmake_minimum_required(VERSION 3.4.3)<br>
<br>
# FIXME: It may be removed when we use 2.8.12.<br>
if(CMAKE_VERSION VERSION_LESS 2.8.12)<br>
<br>
Modified: compiler-rt/trunk/lib/builtins/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/CMakeLists.txt?rev=271327&r1=271326&r2=271327&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/CMakeLists.txt?rev=271327&r1=271326&r2=271327&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/builtins/CMakeLists.txt (original)<br>
+++ compiler-rt/trunk/lib/builtins/CMakeLists.txt Tue May 31 15:21:42 2016<br>
@@ -3,7 +3,7 @@<br>
# architecture-specific code in various subdirectories.<br>
<br>
if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)<br>
- cmake_minimum_required(VERSION 2.8.12.1)<br>
+ cmake_minimum_required(VERSION 3.4.3)<br>
<br>
project(CompilerRTBuiltins C ASM)<br>
set(COMPILER_RT_STANDALONE_BUILD TRUE)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></div></blockquote></div><br></div>